* [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets
@ 2024-01-20 9:23 Vitezslav Samel
2024-01-24 20:30 ` Jakub Kicinski
0 siblings, 1 reply; 10+ messages in thread
From: Vitezslav Samel @ 2024-01-20 9:23 UTC (permalink / raw)
To: Heng Guo; +Cc: netdev
Hi!
In short:
since commit e4da8c78973c ("net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated")
the "Ip6OutOctets" entry of /proc/net/dev_snmp6/<interface> isn't
incremented by packet size for outbound forwarded unicast IPv6 packets.
In more detail:
After move from kernel 6.1.y to 6.6.y I was surprised by very low IPv6 to
IPv4 outgoing traffic ratio counted from /proc/net/... counters on our linux
router. In this simple scenario:
NET1 <--> ROUTER <--> NET2
the entry Ip6OutOctets of ROUTER's /proc/net/dev_snmp6/<interface> was
surprisingly low although the IPv6 traffic between NET1 and NET2 is rather
huge comparing to IPv4 traffic. The bisection led me to commit e4da8c78973c.
After reverting it, the numbers went to expected values.
Numbers for local outbound IPv6 seems correct, as well as numbers for IPv4.
Since the commit patches both IPv4 and IPv6 reverting it doesn't seem like
the right thing to do. Can you, please, look at it and cook some fix?
Thanks,
Vita
#### git bisect log
git bisect start '--' 'include' 'net'
# status: waiting for both good and bad commits
# good: [fb2635ac69abac0060cc2be2873dc4f524f12e66] Linux 6.1.62
git bisect good fb2635ac69abac0060cc2be2873dc4f524f12e66
# status: waiting for bad commit, 1 good commit known
# bad: [5e9df83a705290c4d974693097df1da9cbe25854] Linux 6.6.9
git bisect bad 5e9df83a705290c4d974693097df1da9cbe25854
# good: [830b3c68c1fb1e9176028d02ef86f3cf76aa2476] Linux 6.1
git bisect good 830b3c68c1fb1e9176028d02ef86f3cf76aa2476
# good: [6e98b09da931a00bf4e0477d0fa52748bf28fcce] Merge tag 'net-next-6.4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
git bisect good 6e98b09da931a00bf4e0477d0fa52748bf28fcce
# good: [9b39f758974ff8dfa721e68c6cecfd37e6ddb206] Merge tag 'nf-23-07-20' of https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf
git bisect good 9b39f758974ff8dfa721e68c6cecfd37e6ddb206
# good: [38663034491d00652ac599fa48866bcf2ebd7bc1] Merge tag 'fsnotify_for_v6.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs
git bisect good 38663034491d00652ac599fa48866bcf2ebd7bc1
# good: [7ba2090ca64ea1aa435744884124387db1fac70f] Merge tag 'ceph-for-6.6-rc1' of https://github.com/ceph/ceph-client
git bisect good 7ba2090ca64ea1aa435744884124387db1fac70f
# bad: [ea1cc20cd4ce55dd920a87a317c43da03ccea192] Merge tag 'v6.6-rc7.vfs.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
git bisect bad ea1cc20cd4ce55dd920a87a317c43da03ccea192
# bad: [b938790e70540bf4f2e653dcd74b232494d06c8f] Bluetooth: hci_codec: Fix leaking content of local_codecs
git bisect bad b938790e70540bf4f2e653dcd74b232494d06c8f
# bad: [6912e724832c47bb381eb1bd1e483ec8df0d0f0f] net/smc: bugfix for smcr v2 server connect success statistic
git bisect bad 6912e724832c47bb381eb1bd1e483ec8df0d0f0f
# bad: [c3b704d4a4a265660e665df51b129e8425216ed1] igmp: limit igmpv3_newpack() packet size to IP_MAX_MTU
git bisect bad c3b704d4a4a265660e665df51b129e8425216ed1
# bad: [82ba0ff7bf0483d962e592017bef659ae022d754] net/handshake: fix null-ptr-deref in handshake_nl_done_doit()
git bisect bad 82ba0ff7bf0483d962e592017bef659ae022d754
# bad: [dc9511dd6f37fe803f6b15b61b030728d7057417] sctp: annotate data-races around sk->sk_wmem_queued
git bisect bad dc9511dd6f37fe803f6b15b61b030728d7057417
# good: [7e9be1124dbe7888907e82cab20164578e3f9ab7] netfilter: nf_tables: Audit log setelem reset
git bisect good 7e9be1124dbe7888907e82cab20164578e3f9ab7
# bad: [4e60de1e4769066aa9956c83545c8fa21847f326] Merge tag 'nf-23-08-31' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf
git bisect bad 4e60de1e4769066aa9956c83545c8fa21847f326
# bad: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated
git bisect bad e4da8c78973c1e307c0431e0b99a969ffb8aa3f1
# first bad commit: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-20 9:23 [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets Vitezslav Samel @ 2024-01-24 20:30 ` Jakub Kicinski 2024-01-24 21:55 ` David Ahern 0 siblings, 1 reply; 10+ messages in thread From: Jakub Kicinski @ 2024-01-24 20:30 UTC (permalink / raw) To: Heng Guo, David Ahern; +Cc: Vitezslav Samel, netdev Thanks for the analysis, Vitezslav! Heng Guo, David, any thoughts on this? Revert? On Sat, 20 Jan 2024 10:23:18 +0100 Vitezslav Samel wrote: > Hi! > > In short: > > since commit e4da8c78973c ("net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated") > the "Ip6OutOctets" entry of /proc/net/dev_snmp6/<interface> isn't > incremented by packet size for outbound forwarded unicast IPv6 packets. > > > In more detail: > > After move from kernel 6.1.y to 6.6.y I was surprised by very low IPv6 to > IPv4 outgoing traffic ratio counted from /proc/net/... counters on our linux > router. In this simple scenario: > > NET1 <--> ROUTER <--> NET2 > > the entry Ip6OutOctets of ROUTER's /proc/net/dev_snmp6/<interface> was > surprisingly low although the IPv6 traffic between NET1 and NET2 is rather > huge comparing to IPv4 traffic. The bisection led me to commit e4da8c78973c. > After reverting it, the numbers went to expected values. > > Numbers for local outbound IPv6 seems correct, as well as numbers for IPv4. > > Since the commit patches both IPv4 and IPv6 reverting it doesn't seem like > the right thing to do. Can you, please, look at it and cook some fix? > > Thanks, > > Vita > > #### git bisect log > > git bisect start '--' 'include' 'net' > # status: waiting for both good and bad commits > # good: [fb2635ac69abac0060cc2be2873dc4f524f12e66] Linux 6.1.62 > git bisect good fb2635ac69abac0060cc2be2873dc4f524f12e66 > # status: waiting for bad commit, 1 good commit known > # bad: [5e9df83a705290c4d974693097df1da9cbe25854] Linux 6.6.9 > git bisect bad 5e9df83a705290c4d974693097df1da9cbe25854 > # good: [830b3c68c1fb1e9176028d02ef86f3cf76aa2476] Linux 6.1 > git bisect good 830b3c68c1fb1e9176028d02ef86f3cf76aa2476 > # good: [6e98b09da931a00bf4e0477d0fa52748bf28fcce] Merge tag 'net-next-6.4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next > git bisect good 6e98b09da931a00bf4e0477d0fa52748bf28fcce > # good: [9b39f758974ff8dfa721e68c6cecfd37e6ddb206] Merge tag 'nf-23-07-20' of https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf > git bisect good 9b39f758974ff8dfa721e68c6cecfd37e6ddb206 > # good: [38663034491d00652ac599fa48866bcf2ebd7bc1] Merge tag 'fsnotify_for_v6.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs > git bisect good 38663034491d00652ac599fa48866bcf2ebd7bc1 > # good: [7ba2090ca64ea1aa435744884124387db1fac70f] Merge tag 'ceph-for-6.6-rc1' of https://github.com/ceph/ceph-client > git bisect good 7ba2090ca64ea1aa435744884124387db1fac70f > # bad: [ea1cc20cd4ce55dd920a87a317c43da03ccea192] Merge tag 'v6.6-rc7.vfs.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs > git bisect bad ea1cc20cd4ce55dd920a87a317c43da03ccea192 > # bad: [b938790e70540bf4f2e653dcd74b232494d06c8f] Bluetooth: hci_codec: Fix leaking content of local_codecs > git bisect bad b938790e70540bf4f2e653dcd74b232494d06c8f > # bad: [6912e724832c47bb381eb1bd1e483ec8df0d0f0f] net/smc: bugfix for smcr v2 server connect success statistic > git bisect bad 6912e724832c47bb381eb1bd1e483ec8df0d0f0f > # bad: [c3b704d4a4a265660e665df51b129e8425216ed1] igmp: limit igmpv3_newpack() packet size to IP_MAX_MTU > git bisect bad c3b704d4a4a265660e665df51b129e8425216ed1 > # bad: [82ba0ff7bf0483d962e592017bef659ae022d754] net/handshake: fix null-ptr-deref in handshake_nl_done_doit() > git bisect bad 82ba0ff7bf0483d962e592017bef659ae022d754 > # bad: [dc9511dd6f37fe803f6b15b61b030728d7057417] sctp: annotate data-races around sk->sk_wmem_queued > git bisect bad dc9511dd6f37fe803f6b15b61b030728d7057417 > # good: [7e9be1124dbe7888907e82cab20164578e3f9ab7] netfilter: nf_tables: Audit log setelem reset > git bisect good 7e9be1124dbe7888907e82cab20164578e3f9ab7 > # bad: [4e60de1e4769066aa9956c83545c8fa21847f326] Merge tag 'nf-23-08-31' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf > git bisect bad 4e60de1e4769066aa9956c83545c8fa21847f326 > # bad: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated > git bisect bad e4da8c78973c1e307c0431e0b99a969ffb8aa3f1 > # first bad commit: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-24 20:30 ` Jakub Kicinski @ 2024-01-24 21:55 ` David Ahern 2024-01-25 0:37 ` heng guo 0 siblings, 1 reply; 10+ messages in thread From: David Ahern @ 2024-01-24 21:55 UTC (permalink / raw) To: Jakub Kicinski, Heng Guo; +Cc: Vitezslav Samel, netdev On 1/24/24 1:30 PM, Jakub Kicinski wrote: > Thanks for the analysis, Vitezslav! > > Heng Guo, David, any thoughts on this? Revert? Revert is best; Heng Guo can revisit the math and try again. The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it shown in proc but never bumped in the datapath. > > On Sat, 20 Jan 2024 10:23:18 +0100 Vitezslav Samel wrote: >> Hi! >> >> In short: >> >> since commit e4da8c78973c ("net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated") >> the "Ip6OutOctets" entry of /proc/net/dev_snmp6/<interface> isn't >> incremented by packet size for outbound forwarded unicast IPv6 packets. >> >> >> In more detail: >> >> After move from kernel 6.1.y to 6.6.y I was surprised by very low IPv6 to >> IPv4 outgoing traffic ratio counted from /proc/net/... counters on our linux >> router. In this simple scenario: >> >> NET1 <--> ROUTER <--> NET2 >> >> the entry Ip6OutOctets of ROUTER's /proc/net/dev_snmp6/<interface> was >> surprisingly low although the IPv6 traffic between NET1 and NET2 is rather >> huge comparing to IPv4 traffic. The bisection led me to commit e4da8c78973c. >> After reverting it, the numbers went to expected values. >> >> Numbers for local outbound IPv6 seems correct, as well as numbers for IPv4. >> >> Since the commit patches both IPv4 and IPv6 reverting it doesn't seem like >> the right thing to do. Can you, please, look at it and cook some fix? >> >> Thanks, >> >> Vita >> >> #### git bisect log >> >> git bisect start '--' 'include' 'net' >> # status: waiting for both good and bad commits >> # good: [fb2635ac69abac0060cc2be2873dc4f524f12e66] Linux 6.1.62 >> git bisect good fb2635ac69abac0060cc2be2873dc4f524f12e66 >> # status: waiting for bad commit, 1 good commit known >> # bad: [5e9df83a705290c4d974693097df1da9cbe25854] Linux 6.6.9 >> git bisect bad 5e9df83a705290c4d974693097df1da9cbe25854 >> # good: [830b3c68c1fb1e9176028d02ef86f3cf76aa2476] Linux 6.1 >> git bisect good 830b3c68c1fb1e9176028d02ef86f3cf76aa2476 >> # good: [6e98b09da931a00bf4e0477d0fa52748bf28fcce] Merge tag 'net-next-6.4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next >> git bisect good 6e98b09da931a00bf4e0477d0fa52748bf28fcce >> # good: [9b39f758974ff8dfa721e68c6cecfd37e6ddb206] Merge tag 'nf-23-07-20' of https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf >> git bisect good 9b39f758974ff8dfa721e68c6cecfd37e6ddb206 >> # good: [38663034491d00652ac599fa48866bcf2ebd7bc1] Merge tag 'fsnotify_for_v6.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs >> git bisect good 38663034491d00652ac599fa48866bcf2ebd7bc1 >> # good: [7ba2090ca64ea1aa435744884124387db1fac70f] Merge tag 'ceph-for-6.6-rc1' of https://github.com/ceph/ceph-client >> git bisect good 7ba2090ca64ea1aa435744884124387db1fac70f >> # bad: [ea1cc20cd4ce55dd920a87a317c43da03ccea192] Merge tag 'v6.6-rc7.vfs.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs >> git bisect bad ea1cc20cd4ce55dd920a87a317c43da03ccea192 >> # bad: [b938790e70540bf4f2e653dcd74b232494d06c8f] Bluetooth: hci_codec: Fix leaking content of local_codecs >> git bisect bad b938790e70540bf4f2e653dcd74b232494d06c8f >> # bad: [6912e724832c47bb381eb1bd1e483ec8df0d0f0f] net/smc: bugfix for smcr v2 server connect success statistic >> git bisect bad 6912e724832c47bb381eb1bd1e483ec8df0d0f0f >> # bad: [c3b704d4a4a265660e665df51b129e8425216ed1] igmp: limit igmpv3_newpack() packet size to IP_MAX_MTU >> git bisect bad c3b704d4a4a265660e665df51b129e8425216ed1 >> # bad: [82ba0ff7bf0483d962e592017bef659ae022d754] net/handshake: fix null-ptr-deref in handshake_nl_done_doit() >> git bisect bad 82ba0ff7bf0483d962e592017bef659ae022d754 >> # bad: [dc9511dd6f37fe803f6b15b61b030728d7057417] sctp: annotate data-races around sk->sk_wmem_queued >> git bisect bad dc9511dd6f37fe803f6b15b61b030728d7057417 >> # good: [7e9be1124dbe7888907e82cab20164578e3f9ab7] netfilter: nf_tables: Audit log setelem reset >> git bisect good 7e9be1124dbe7888907e82cab20164578e3f9ab7 >> # bad: [4e60de1e4769066aa9956c83545c8fa21847f326] Merge tag 'nf-23-08-31' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf >> git bisect bad 4e60de1e4769066aa9956c83545c8fa21847f326 >> # bad: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated >> git bisect bad e4da8c78973c1e307c0431e0b99a969ffb8aa3f1 >> # first bad commit: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated >> >> > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-24 21:55 ` David Ahern @ 2024-01-25 0:37 ` heng guo 2024-01-25 1:46 ` Jakub Kicinski 0 siblings, 1 reply; 10+ messages in thread From: heng guo @ 2024-01-25 0:37 UTC (permalink / raw) To: David Ahern, Jakub Kicinski; +Cc: Vitezslav Samel, netdev On 1/25/24 05:55, David Ahern wrote: > CAUTION: This email comes from a non Wind River email account! > Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On 1/24/24 1:30 PM, Jakub Kicinski wrote: >> Thanks for the analysis, Vitezslav! >> >> Heng Guo, David, any thoughts on this? Revert? > Revert is best; Heng Guo can revisit the math and try again. > > The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it > shown in proc but never bumped in the datapath. [HG]: Yes please revert it. I verified the patch on ipv4, seems I should not touch the codes to ipv6. Sorry for it. >> On Sat, 20 Jan 2024 10:23:18 +0100 Vitezslav Samel wrote: >>> Hi! >>> >>> In short: >>> >>> since commit e4da8c78973c ("net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated") >>> the "Ip6OutOctets" entry of /proc/net/dev_snmp6/<interface> isn't >>> incremented by packet size for outbound forwarded unicast IPv6 packets. >>> >>> >>> In more detail: >>> >>> After move from kernel 6.1.y to 6.6.y I was surprised by very low IPv6 to >>> IPv4 outgoing traffic ratio counted from /proc/net/... counters on our linux >>> router. In this simple scenario: >>> >>> NET1 <--> ROUTER <--> NET2 >>> >>> the entry Ip6OutOctets of ROUTER's /proc/net/dev_snmp6/<interface> was >>> surprisingly low although the IPv6 traffic between NET1 and NET2 is rather >>> huge comparing to IPv4 traffic. The bisection led me to commit e4da8c78973c. >>> After reverting it, the numbers went to expected values. >>> >>> Numbers for local outbound IPv6 seems correct, as well as numbers for IPv4. >>> >>> Since the commit patches both IPv4 and IPv6 reverting it doesn't seem like >>> the right thing to do. Can you, please, look at it and cook some fix? >>> >>> Thanks, >>> >>> Vita >>> >>> #### git bisect log >>> >>> git bisect start '--' 'include' 'net' >>> # status: waiting for both good and bad commits >>> # good: [fb2635ac69abac0060cc2be2873dc4f524f12e66] Linux 6.1.62 >>> git bisect good fb2635ac69abac0060cc2be2873dc4f524f12e66 >>> # status: waiting for bad commit, 1 good commit known >>> # bad: [5e9df83a705290c4d974693097df1da9cbe25854] Linux 6.6.9 >>> git bisect bad 5e9df83a705290c4d974693097df1da9cbe25854 >>> # good: [830b3c68c1fb1e9176028d02ef86f3cf76aa2476] Linux 6.1 >>> git bisect good 830b3c68c1fb1e9176028d02ef86f3cf76aa2476 >>> # good: [6e98b09da931a00bf4e0477d0fa52748bf28fcce] Merge tag 'net-next-6.4' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next >>> git bisect good 6e98b09da931a00bf4e0477d0fa52748bf28fcce >>> # good: [9b39f758974ff8dfa721e68c6cecfd37e6ddb206] Merge tag 'nf-23-07-20' of https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf >>> git bisect good 9b39f758974ff8dfa721e68c6cecfd37e6ddb206 >>> # good: [38663034491d00652ac599fa48866bcf2ebd7bc1] Merge tag 'fsnotify_for_v6.6-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs >>> git bisect good 38663034491d00652ac599fa48866bcf2ebd7bc1 >>> # good: [7ba2090ca64ea1aa435744884124387db1fac70f] Merge tag 'ceph-for-6.6-rc1' of https://github.com/ceph/ceph-client >>> git bisect good 7ba2090ca64ea1aa435744884124387db1fac70f >>> # bad: [ea1cc20cd4ce55dd920a87a317c43da03ccea192] Merge tag 'v6.6-rc7.vfs.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs >>> git bisect bad ea1cc20cd4ce55dd920a87a317c43da03ccea192 >>> # bad: [b938790e70540bf4f2e653dcd74b232494d06c8f] Bluetooth: hci_codec: Fix leaking content of local_codecs >>> git bisect bad b938790e70540bf4f2e653dcd74b232494d06c8f >>> # bad: [6912e724832c47bb381eb1bd1e483ec8df0d0f0f] net/smc: bugfix for smcr v2 server connect success statistic >>> git bisect bad 6912e724832c47bb381eb1bd1e483ec8df0d0f0f >>> # bad: [c3b704d4a4a265660e665df51b129e8425216ed1] igmp: limit igmpv3_newpack() packet size to IP_MAX_MTU >>> git bisect bad c3b704d4a4a265660e665df51b129e8425216ed1 >>> # bad: [82ba0ff7bf0483d962e592017bef659ae022d754] net/handshake: fix null-ptr-deref in handshake_nl_done_doit() >>> git bisect bad 82ba0ff7bf0483d962e592017bef659ae022d754 >>> # bad: [dc9511dd6f37fe803f6b15b61b030728d7057417] sctp: annotate data-races around sk->sk_wmem_queued >>> git bisect bad dc9511dd6f37fe803f6b15b61b030728d7057417 >>> # good: [7e9be1124dbe7888907e82cab20164578e3f9ab7] netfilter: nf_tables: Audit log setelem reset >>> git bisect good 7e9be1124dbe7888907e82cab20164578e3f9ab7 >>> # bad: [4e60de1e4769066aa9956c83545c8fa21847f326] Merge tag 'nf-23-08-31' of git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf >>> git bisect bad 4e60de1e4769066aa9956c83545c8fa21847f326 >>> # bad: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated >>> git bisect bad e4da8c78973c1e307c0431e0b99a969ffb8aa3f1 >>> # first bad commit: [e4da8c78973c1e307c0431e0b99a969ffb8aa3f1] net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated >>> >>> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-25 0:37 ` heng guo @ 2024-01-25 1:46 ` Jakub Kicinski 2024-01-25 6:47 ` Vitezslav Samel 0 siblings, 1 reply; 10+ messages in thread From: Jakub Kicinski @ 2024-01-25 1:46 UTC (permalink / raw) To: heng guo; +Cc: David Ahern, Vitezslav Samel, netdev On Thu, 25 Jan 2024 08:37:11 +0800 heng guo wrote: > >> Heng Guo, David, any thoughts on this? Revert? > > Revert is best; Heng Guo can revisit the math and try again. > > > > The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it > > shown in proc but never bumped in the datapath. > [HG]: Yes please revert it. I verified the patch on ipv4, seems I should > not touch the codes to ipv6. Sorry for it. Would you mind sending a patch with a revert, explaining the situation, the right Fixes tag and a link to Vitezslav's report? ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-25 1:46 ` Jakub Kicinski @ 2024-01-25 6:47 ` Vitezslav Samel 2024-01-25 15:08 ` Vitezslav Samel 0 siblings, 1 reply; 10+ messages in thread From: Vitezslav Samel @ 2024-01-25 6:47 UTC (permalink / raw) To: Jakub Kicinski; +Cc: heng guo, David Ahern, netdev On Wed, Jan 24, 2024 at 17:46:52 -0800, Jakub Kicinski wrote: > On Thu, 25 Jan 2024 08:37:11 +0800 heng guo wrote: > > >> Heng Guo, David, any thoughts on this? Revert? > > > Revert is best; Heng Guo can revisit the math and try again. > > > > > > The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it > > > shown in proc but never bumped in the datapath. > > [HG]: Yes please revert it. I verified the patch on ipv4, seems I should > > not touch the codes to ipv6. Sorry for it. > > Would you mind sending a patch with a revert, explaining the situation, > the right Fixes tag and a link to Vitezslav's report? I took a look at current master and found that there is yet another commit since 6.6.x which touches this area: commit b4a11b2033b7 by Heng Guo ("net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams"). It went in v6.7-rc1. I will test current master this afternoon and report back. Vita ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-25 6:47 ` Vitezslav Samel @ 2024-01-25 15:08 ` Vitezslav Samel 2024-01-25 18:20 ` David Ahern 0 siblings, 1 reply; 10+ messages in thread From: Vitezslav Samel @ 2024-01-25 15:08 UTC (permalink / raw) To: Jakub Kicinski; +Cc: David Ahern, heng guo, netdev On Thu, Jan 25, 2024 at 07:47:40 +0100, Vitezslav Samel wrote: > On Wed, Jan 24, 2024 at 17:46:52 -0800, Jakub Kicinski wrote: > > On Thu, 25 Jan 2024 08:37:11 +0800 heng guo wrote: > > > >> Heng Guo, David, any thoughts on this? Revert? > > > > Revert is best; Heng Guo can revisit the math and try again. > > > > > > > > The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it > > > > shown in proc but never bumped in the datapath. > > > [HG]: Yes please revert it. I verified the patch on ipv4, seems I should > > > not touch the codes to ipv6. Sorry for it. > > > > Would you mind sending a patch with a revert, explaining the situation, > > the right Fixes tag and a link to Vitezslav's report? > > I took a look at current master and found that there is yet another > commit since 6.6.x which touches this area: commit b4a11b2033b7 by Heng Guo > ("net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams"). It went > in v6.7-rc1. > > I will test current master this afternoon and report back. Test 1: Linus' current master: IPv6 octets accounting is OK Test 2: 6.6.13 with b4a11b2033b7 ("net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams") on top is also OK. Seems like my problem was solved in master already, but it still exists in 6.6.y. IMHO commit b4a11b2033b7 should be marked as for-stable-6.6.y and forwarded to GregKH. AFAIK only 6.6.y stable tree is affected. But beware: I only tested my specific problem and I don't know if the commit with fix doesn't break anything else. Thanks, Vita ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets 2024-01-25 15:08 ` Vitezslav Samel @ 2024-01-25 18:20 ` David Ahern 2024-03-05 14:38 ` fix IPSTATS_MIB_OUTOCTETS for IPv6 in stable-6.6.x Vitezslav Samel 0 siblings, 1 reply; 10+ messages in thread From: David Ahern @ 2024-01-25 18:20 UTC (permalink / raw) To: Jakub Kicinski, heng guo, netdev On 1/25/24 8:08 AM, Vitezslav Samel wrote: > On Thu, Jan 25, 2024 at 07:47:40 +0100, Vitezslav Samel wrote: >> On Wed, Jan 24, 2024 at 17:46:52 -0800, Jakub Kicinski wrote: >>> On Thu, 25 Jan 2024 08:37:11 +0800 heng guo wrote: >>>>>> Heng Guo, David, any thoughts on this? Revert? >>>>> Revert is best; Heng Guo can revisit the math and try again. >>>>> >>>>> The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it >>>>> shown in proc but never bumped in the datapath. >>>> [HG]: Yes please revert it. I verified the patch on ipv4, seems I should >>>> not touch the codes to ipv6. Sorry for it. >>> >>> Would you mind sending a patch with a revert, explaining the situation, >>> the right Fixes tag and a link to Vitezslav's report? >> >> I took a look at current master and found that there is yet another >> commit since 6.6.x which touches this area: commit b4a11b2033b7 by Heng Guo >> ("net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams"). It went >> in v6.7-rc1. >> >> I will test current master this afternoon and report back. > > Test 1: Linus' current master: IPv6 octets accounting is OK > Test 2: 6.6.13 with b4a11b2033b7 ("net: fix IPSTATS_MIB_OUTPKGS > increment in OutForwDatagrams") on top is also OK. > > Seems like my problem was solved in master already, but > it still exists in 6.6.y. IMHO commit b4a11b2033b7 should be > marked as for-stable-6.6.y and forwarded to GregKH. AFAIK only 6.6.y > stable tree is affected. > > But beware: I only tested my specific problem and I don't know if the > commit with fix doesn't break anything else. Only reported problem, so with b4a11b2033b7 backported to stable we should be good. Thanks for the testing of various releases to isolate the problem. ^ permalink raw reply [flat|nested] 10+ messages in thread
* fix IPSTATS_MIB_OUTOCTETS for IPv6 in stable-6.6.x 2024-01-25 18:20 ` David Ahern @ 2024-03-05 14:38 ` Vitezslav Samel 2024-03-27 14:37 ` Greg KH 0 siblings, 1 reply; 10+ messages in thread From: Vitezslav Samel @ 2024-03-05 14:38 UTC (permalink / raw) To: stable; +Cc: David Ahern, Jakub Kicinski, heng guo, netdev Hi, could you, please, include commit b4a11b2033b7 ("net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams") from Linus' tree into the 6.6 stable tree (only)? Reported-by: Vitezslav Samel <vitezslav@samel.cz> Fixes: e4da8c78973c ("net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated") Link: https://lore.kernel.org/netdev/ZauRBl7zXWQRVZnl@pc11.op.pod.cz/ Tested-by: Vitezslav Samel <vitezslav@samel.cz> Thanks, Vita On Thu, Jan 25, 2024 at 11:20:58 -0700, David Ahern wrote: > On 1/25/24 8:08 AM, Vitezslav Samel wrote: > > On Thu, Jan 25, 2024 at 07:47:40 +0100, Vitezslav Samel wrote: > >> On Wed, Jan 24, 2024 at 17:46:52 -0800, Jakub Kicinski wrote: > >>> On Thu, 25 Jan 2024 08:37:11 +0800 heng guo wrote: > >>>>>> Heng Guo, David, any thoughts on this? Revert? > >>>>> Revert is best; Heng Guo can revisit the math and try again. > >>>>> > >>>>> The patch in question basically negated IPSTATS_MIB_OUTOCTETS; I see it > >>>>> shown in proc but never bumped in the datapath. > >>>> [HG]: Yes please revert it. I verified the patch on ipv4, seems I should > >>>> not touch the codes to ipv6. Sorry for it. > >>> > >>> Would you mind sending a patch with a revert, explaining the situation, > >>> the right Fixes tag and a link to Vitezslav's report? > >> > >> I took a look at current master and found that there is yet another > >> commit since 6.6.x which touches this area: commit b4a11b2033b7 by Heng Guo > >> ("net: fix IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams"). It went > >> in v6.7-rc1. > >> > >> I will test current master this afternoon and report back. > > > > Test 1: Linus' current master: IPv6 octets accounting is OK > > Test 2: 6.6.13 with b4a11b2033b7 ("net: fix IPSTATS_MIB_OUTPKGS > > increment in OutForwDatagrams") on top is also OK. > > > > Seems like my problem was solved in master already, but > > it still exists in 6.6.y. IMHO commit b4a11b2033b7 should be > > marked as for-stable-6.6.y and forwarded to GregKH. AFAIK only 6.6.y > > stable tree is affected. > > > > But beware: I only tested my specific problem and I don't know if the > > commit with fix doesn't break anything else. > > Only reported problem, so with b4a11b2033b7 backported to stable we > should be good. Thanks for the testing of various releases to isolate > the problem. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: fix IPSTATS_MIB_OUTOCTETS for IPv6 in stable-6.6.x 2024-03-05 14:38 ` fix IPSTATS_MIB_OUTOCTETS for IPv6 in stable-6.6.x Vitezslav Samel @ 2024-03-27 14:37 ` Greg KH 0 siblings, 0 replies; 10+ messages in thread From: Greg KH @ 2024-03-27 14:37 UTC (permalink / raw) To: stable, David Ahern, Jakub Kicinski, heng guo, netdev On Tue, Mar 05, 2024 at 03:38:09PM +0100, Vitezslav Samel wrote: > Hi, > > could you, please, include commit b4a11b2033b7 ("net: fix > IPSTATS_MIB_OUTPKGS increment in OutForwDatagrams") from Linus' tree > into the 6.6 stable tree (only)? > > Reported-by: Vitezslav Samel <vitezslav@samel.cz> > Fixes: e4da8c78973c ("net: ipv4, ipv6: fix IPSTATS_MIB_OUTOCTETS increment duplicated") > Link: https://lore.kernel.org/netdev/ZauRBl7zXWQRVZnl@pc11.op.pod.cz/ > Tested-by: Vitezslav Samel <vitezslav@samel.cz> Now queued up, thanks. greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2024-03-27 14:37 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-01-20 9:23 [6.6.x REGRESSION][BISECTED] dev_snmp6: broken Ip6OutOctets accounting for forwarded IPv6 packets Vitezslav Samel 2024-01-24 20:30 ` Jakub Kicinski 2024-01-24 21:55 ` David Ahern 2024-01-25 0:37 ` heng guo 2024-01-25 1:46 ` Jakub Kicinski 2024-01-25 6:47 ` Vitezslav Samel 2024-01-25 15:08 ` Vitezslav Samel 2024-01-25 18:20 ` David Ahern 2024-03-05 14:38 ` fix IPSTATS_MIB_OUTOCTETS for IPv6 in stable-6.6.x Vitezslav Samel 2024-03-27 14:37 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).