From: Jakub Kicinski <kuba@kernel.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Leone Fernando <leone4fernando@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net] ipmr: fix kernel panic when forwarding mcast packets
Date: Wed, 24 Jan 2024 15:23:13 -0800 [thread overview]
Message-ID: <20240124152313.506bdfab@kernel.org> (raw)
In-Reply-To: <20240124121538.3188769-1-nicolas.dichtel@6wind.com>
On Wed, 24 Jan 2024 13:15:38 +0100 Nicolas Dichtel wrote:
> --- a/net/ipv4/ip_sockglue.c
> +++ b/net/ipv4/ip_sockglue.c
> @@ -1368,7 +1368,7 @@ int do_ip_setsockopt(struct sock *sk, int level, int optname,
> * destination in skb->cb[] before dst drop.
> * This way, receiver doesn't make cache line misses to read rtable.
> */
> -void ipv4_pktinfo_prepare(const struct sock *sk, struct sk_buff *skb)
> +void ipv4_pktinfo_prepare(const struct sock *sk, struct sk_buff *skb, bool keep_dst)
kdoc missing here:
net/ipv4/ip_sockglue.c:1373: warning: Function parameter or struct member 'keep_dst' not described in 'ipv4_pktinfo_prepare'
--
pw-bot: cr
next prev parent reply other threads:[~2024-01-24 23:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 12:15 [PATCH net] ipmr: fix kernel panic when forwarding mcast packets Nicolas Dichtel
2024-01-24 14:21 ` Eric Dumazet
2024-01-24 14:24 ` Nicolas Dichtel
2024-01-24 23:23 ` Jakub Kicinski [this message]
2024-01-25 9:46 ` Leone Fernando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124152313.506bdfab@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leone4fernando@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).