From: Victor Nogueira <victor@mojatatu.com>
To: stephen@networkplumber.org, dsahern@kernel.org, netdev@vger.kernel.org
Cc: liuhangbin@gmail.com, jhs@mojatatu.com, kernel@mojatatu.com
Subject: [PATCH iproute2-next 0/2] tc: add NLM_F_ECHO support for actions and filters
Date: Wed, 24 Jan 2024 12:34:54 -0300 [thread overview]
Message-ID: <20240124153456.117048-1-victor@mojatatu.com> (raw)
Continuing on what Hangbin Liu started [1], this patch set adds support for
the NLM_F_ECHO flag for tc actions and filters. For qdiscs it will require
some kernel surgery, and we'll send it soon after this surgery is merged.
When user space configures the kernel with netlink messages, it can set
NLM_F_ECHO flag to request the kernel to send the applied configuration
back to the caller. This allows user space to receive back configuration
information that is populated by the kernel. Often because there are
parameters that can only be set by the kernel which become visible with the
echo, or because user space lets the kernel choose a default value.
To illustrate a use case where the kernel will give us a default value,
the example below shows the user not specifying the action index:
tc -echo actions add action mirred egress mirror dev lo
total acts 0
Added action
action order 1: mirred (Egress Mirror to device lo) pipe
index 1 ref 1 bind 0
not_in_hw
Note that the echoed response indicates that the kernel gave us a value
of index 1
[1] https://lore.kernel.org/netdev/20220916033428.400131-2-liuhangbin@gmail.com/
Victor Nogueira (2):
tc: add NLM_F_ECHO support for actions
tc: Add NLM_F_ECHO support for filters
man/man8/tc.8 | 6 +++++-
tc/m_action.c | 25 ++++++++++++++++++++++---
tc/tc.c | 6 +++++-
tc/tc_filter.c | 8 +++++++-
4 files changed, 39 insertions(+), 6 deletions(-)
--
2.25.1
next reply other threads:[~2024-01-24 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 15:34 Victor Nogueira [this message]
2024-01-24 15:34 ` [PATCH iproute2-next 1/2] tc: add NLM_F_ECHO support for actions Victor Nogueira
2024-01-24 15:34 ` [PATCH iproute2-next 2/2] tc: Add NLM_F_ECHO support for filters Victor Nogueira
2024-01-25 2:37 ` [PATCH iproute2-next 0/2] tc: add NLM_F_ECHO support for actions and filters Hangbin Liu
2024-01-30 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124153456.117048-1-victor@mojatatu.com \
--to=victor@mojatatu.com \
--cc=dsahern@kernel.org \
--cc=jhs@mojatatu.com \
--cc=kernel@mojatatu.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox