From: Jakub Kicinski <kuba@kernel.org>
To: Benjamin Poirier <bpoirier@nvidia.com>
Cc: netdev@vger.kernel.org, Shuah Khan <shuah@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Petr Machata <petrm@nvidia.com>,
Danielle Ratson <danieller@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Ido Schimmel <idosch@nvidia.com>,
Johannes Nixdorf <jnixdorf-oss@avm.de>,
Davide Caratti <dcaratti@redhat.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
Zahari Doychev <zdoychev@maxlinear.com>,
Hangbin Liu <liuhangbin@gmail.com>,
linux-kselftest@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next 1/6] selftests: Introduce Makefile variable to list shared bash scripts
Date: Wed, 24 Jan 2024 20:46:12 -0800 [thread overview]
Message-ID: <20240124204612.4c688095@kernel.org> (raw)
In-Reply-To: <20240124170222.261664-2-bpoirier@nvidia.com>
On Wed, 24 Jan 2024 12:02:17 -0500 Benjamin Poirier wrote:
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -255,9 +255,19 @@ Contributing new tests (details)
>
> TEST_PROGS_EXTENDED, TEST_GEN_PROGS_EXTENDED mean it is the
> executable which is not tested by default.
> +
> TEST_FILES, TEST_GEN_FILES mean it is the file which is used by
> test.
>
> + TEST_INCLUDES is similar to TEST_FILES, it lists files which should be
> + included when exporting or installing the tests, with the following
> + differences:
> + * symlinks to files in other directories are preserved
> + * the part of paths below tools/testing/selftests/ is preserved when copying
> + the files to the output directory
> + TEST_INCLUDES is meant to list dependencies located in other directories of
> + the selftests hierarchy.
> +
I think that this chunk causes a warning when doing make htmldocs:
Documentation/dev-tools/kselftest.rst:267: WARNING: Unexpected indentation.
Documentation/dev-tools/kselftest.rst:268: WARNING: Block quote ends without a blank line; unexpected unindent.
Could you double-check?
next prev parent reply other threads:[~2024-01-25 4:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 17:02 [PATCH net-next 0/6] selftests: Add TEST_INCLUDES directive and adjust tests to use it Benjamin Poirier
2024-01-24 17:02 ` [PATCH net-next 1/6] selftests: Introduce Makefile variable to list shared bash scripts Benjamin Poirier
2024-01-25 4:46 ` Jakub Kicinski [this message]
2024-01-25 16:43 ` Benjamin Poirier
2024-01-24 17:02 ` [PATCH net-next 2/6] selftests: bonding: Add net/forwarding/lib.sh to TEST_INCLUDES Benjamin Poirier
2024-01-24 18:24 ` Jay Vosburgh
2024-01-24 19:27 ` Benjamin Poirier
2024-01-25 1:04 ` Jay Vosburgh
2024-01-25 4:04 ` Hangbin Liu
2024-01-24 17:02 ` [PATCH net-next 3/6] selftests: team: Add shared library scripts " Benjamin Poirier
2024-01-24 17:02 ` [PATCH net-next 4/6] selftests: dsa: Replace test symlinks by wrapper script Benjamin Poirier
2024-01-24 17:02 ` [PATCH net-next 5/6] selftests: forwarding: Redefine relative_path variable Benjamin Poirier
2024-01-24 17:02 ` [PATCH net-next 6/6] selftests: forwarding: Remove duplicated lib.sh content Benjamin Poirier
2024-01-25 4:07 ` [PATCH net-next 0/6] selftests: Add TEST_INCLUDES directive and adjust tests to use it Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124204612.4c688095@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=andy@greyhouse.net \
--cc=bpoirier@nvidia.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@resnulli.us \
--cc=jnixdorf-oss@avm.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=tobias@waldekranz.com \
--cc=zdoychev@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).