From: Jakub Kicinski <kuba@kernel.org>
To: Matthew Wood <thepacketgeek@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
leitao@debian.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v1 5/8] net: netconsole: add a userdata config_group member to netconsole_target
Date: Wed, 24 Jan 2024 21:15:30 -0800 [thread overview]
Message-ID: <20240124211530.77f5e307@kernel.org> (raw)
In-Reply-To: <20240124174711.1906102-6-thepacketgeek@gmail.com>
On Wed, 24 Jan 2024 09:47:03 -0800 Matthew Wood wrote:
> + struct config_group userdata_group;
also kdoc, ./scripts/kernel-doc -none $files will help you check for
warnings
next prev parent reply other threads:[~2024-01-25 5:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-24 17:46 [PATCH net-next v1 0/8] netconsole: Add userdata append support Matthew Wood
2024-01-24 17:46 ` [PATCH net-next v1 1/8] net: netconsole: cleanup formatting lints Matthew Wood
2024-01-24 17:47 ` [PATCH net-next v1 2/8] net: netconsole: move netconsole_target config_item to config_group Matthew Wood
2024-01-25 5:14 ` Jakub Kicinski
2024-01-24 17:47 ` [PATCH net-next v1 3/8] net: netconsole: move newline trimming to function Matthew Wood
2024-01-24 17:47 ` [PATCH net-next v1 4/8] net: netconsole: add docs for appending netconsole user data Matthew Wood
2024-01-24 17:47 ` [PATCH net-next v1 5/8] net: netconsole: add a userdata config_group member to netconsole_target Matthew Wood
2024-01-25 5:15 ` Jakub Kicinski [this message]
2024-01-24 17:47 ` [PATCH net-next v1 6/8] net: netconsole: cache userdata formatted string in netconsole_target Matthew Wood
2024-01-24 17:47 ` [PATCH net-next v1 7/8] net: netconsole: append userdata to netconsole messages Matthew Wood
2024-01-24 17:47 ` [PATCH net-next v1 8/8] net: netconsole: append userdata to fragmented " Matthew Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240124211530.77f5e307@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thepacketgeek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).