* [PATCH iwl-next] ice: remove duplicate comment
@ 2024-01-22 18:24 Tony Nguyen
2024-01-24 21:26 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Tony Nguyen @ 2024-01-22 18:24 UTC (permalink / raw)
To: intel-wired-lan; +Cc: Paul M Stillwell Jr, netdev, Przemek Kitszel
From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Remove a comment that was not correct; this structure has nothing
to do with FW alignment.
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
---
drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
index c2bfba6b9ead..85aa31dd86b1 100644
--- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
+++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
@@ -64,9 +64,6 @@ static const char * const ice_fwlog_level_string[] = {
"verbose",
};
-/* the order in this array is important. it matches the ordering of the
- * values in the FW so the index is the same value as in ice_fwlog_level
- */
static const char * const ice_fwlog_log_size[] = {
"128K",
"256K",
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH iwl-next] ice: remove duplicate comment
2024-01-22 18:24 [PATCH iwl-next] ice: remove duplicate comment Tony Nguyen
@ 2024-01-24 21:26 ` Simon Horman
2024-01-25 17:26 ` Tony Nguyen
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2024-01-24 21:26 UTC (permalink / raw)
To: Tony Nguyen; +Cc: intel-wired-lan, Paul M Stillwell Jr, netdev, Przemek Kitszel
On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> Remove a comment that was not correct; this structure has nothing
> to do with FW alignment.
>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Sure, but the subject doesn't seem to match the patch description.
And, Tony, your Sob seems to be missing.
> ---
> drivers/net/ethernet/intel/ice/ice_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_debugfs.c b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> index c2bfba6b9ead..85aa31dd86b1 100644
> --- a/drivers/net/ethernet/intel/ice/ice_debugfs.c
> +++ b/drivers/net/ethernet/intel/ice/ice_debugfs.c
> @@ -64,9 +64,6 @@ static const char * const ice_fwlog_level_string[] = {
> "verbose",
> };
>
> -/* the order in this array is important. it matches the ordering of the
> - * values in the FW so the index is the same value as in ice_fwlog_level
> - */
> static const char * const ice_fwlog_log_size[] = {
> "128K",
> "256K",
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH iwl-next] ice: remove duplicate comment
2024-01-24 21:26 ` Simon Horman
@ 2024-01-25 17:26 ` Tony Nguyen
0 siblings, 0 replies; 3+ messages in thread
From: Tony Nguyen @ 2024-01-25 17:26 UTC (permalink / raw)
To: Simon Horman
Cc: intel-wired-lan, Paul M Stillwell Jr, netdev, Przemek Kitszel
On 1/24/2024 1:26 PM, Simon Horman wrote:
> On Mon, Jan 22, 2024 at 10:24:17AM -0800, Tony Nguyen wrote:
>> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>>
>> Remove a comment that was not correct; this structure has nothing
>> to do with FW alignment.
>>
>> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
>> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> Sure, but the subject doesn't seem to match the patch description.
> And, Tony, your Sob seems to be missing.
I was just kind of passing the patch along to IWL. I'll modify the
subject to match the description and add my sob when sending on to net-next.
Thanks,
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-25 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-22 18:24 [PATCH iwl-next] ice: remove duplicate comment Tony Nguyen
2024-01-24 21:26 ` Simon Horman
2024-01-25 17:26 ` Tony Nguyen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).