From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Gal Pressman <gal@nvidia.com>, Saeed Mahameed <saeed@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Saeed Mahameed <saeedm@nvidia.com>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [net-next 10/15] net/mlx5e: Let channels be SD-aware
Date: Thu, 25 Jan 2024 18:40:31 -0800 [thread overview]
Message-ID: <20240125184031.5ddc5799@kernel.org> (raw)
In-Reply-To: <4bb155ee-f727-449f-bd88-ba117107a88f@gmail.com>
On Thu, 25 Jan 2024 10:01:05 +0200 Tariq Toukan wrote:
> Exactly. That's the desired configuration.
> Our driver has the logic to set it in default.
>
> Here's the default XPS on my setup:
>
> NUMA:
> NUMA node(s): 2
> NUMA node0 CPU(s): 0-11
> NUMA node1 CPU(s): 12-23
>
> PF0 on node0, PF1 on node1.
Okay, good that you took care of the defaults, but having a queue per
CPU thread is quite inefficient. Most sensible users will reconfigure
your NICs and remap IRQs and XPS. Which is fine, but we need to give
them the necessary info to do this right - documentation and preferably
the PCIe dev mapping in the new netlink queue API.
next prev parent reply other threads:[~2024-01-26 2:40 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-21 0:57 [pull request][net-next 00/15] mlx5 updates 2023-12-20 Saeed Mahameed
2023-12-21 0:57 ` [net-next 01/15] net/mlx5e: Use the correct lag ports number when creating TISes Saeed Mahameed
2023-12-29 22:40 ` patchwork-bot+netdevbpf
2023-12-21 0:57 ` [net-next 02/15] net/mlx5: Fix query of sd_group field Saeed Mahameed
2023-12-21 0:57 ` [net-next 03/15] net/mlx5: SD, Introduce SD lib Saeed Mahameed
2023-12-21 0:57 ` [net-next 04/15] net/mlx5: SD, Implement basic query and instantiation Saeed Mahameed
2024-01-05 12:15 ` Jiri Pirko
2024-01-25 7:34 ` Tariq Toukan
2024-01-29 9:21 ` Jiri Pirko
2023-12-21 0:57 ` [net-next 05/15] net/mlx5: SD, Implement devcom communication and primary election Saeed Mahameed
2023-12-21 0:57 ` [net-next 06/15] net/mlx5: SD, Implement steering for primary and secondaries Saeed Mahameed
2023-12-21 0:57 ` [net-next 07/15] net/mlx5: SD, Add informative prints in kernel log Saeed Mahameed
2024-01-05 12:12 ` Jiri Pirko
2024-01-25 7:42 ` Tariq Toukan
2024-01-29 9:20 ` Jiri Pirko
2023-12-21 0:57 ` [net-next 08/15] net/mlx5e: Create single netdev per SD group Saeed Mahameed
2024-01-08 13:36 ` Aishwarya TCV
2024-01-08 13:50 ` Gal Pressman
2024-01-08 15:54 ` Mark Brown
2024-01-08 16:00 ` Gal Pressman
2023-12-21 0:57 ` [net-next 09/15] net/mlx5e: Create EN core HW resources for all secondary devices Saeed Mahameed
2023-12-21 0:57 ` [net-next 10/15] net/mlx5e: Let channels be SD-aware Saeed Mahameed
2024-01-04 22:50 ` Jakub Kicinski
2024-01-08 12:30 ` Gal Pressman
2024-01-09 3:08 ` Jakub Kicinski
2024-01-09 14:15 ` Gal Pressman
2024-01-09 16:00 ` Jakub Kicinski
2024-01-10 14:09 ` Gal Pressman
2024-01-25 8:01 ` Tariq Toukan
2024-01-26 2:40 ` Jakub Kicinski [this message]
2023-12-21 0:57 ` [net-next 11/15] net/mlx5e: Support cross-vhca RSS Saeed Mahameed
2023-12-21 0:57 ` [net-next 12/15] net/mlx5e: Support per-mdev queue counter Saeed Mahameed
2023-12-21 0:57 ` [net-next 13/15] net/mlx5e: Block TLS device offload on combined SD netdev Saeed Mahameed
2023-12-21 0:57 ` [net-next 14/15] net/mlx5: Enable SD feature Saeed Mahameed
2023-12-21 0:57 ` [net-next 15/15] net/mlx5: Implement management PF Ethernet profile Saeed Mahameed
2023-12-21 2:45 ` Nelson, Shannon
2023-12-21 22:25 ` Saeed Mahameed
2024-01-04 22:44 ` Jakub Kicinski
2024-01-08 23:22 ` Saeed Mahameed
2024-01-09 2:58 ` Jakub Kicinski
2024-01-17 7:37 ` Saeed Mahameed
2024-01-18 2:04 ` Jakub Kicinski
2024-01-04 22:47 ` [pull request][net-next 00/15] mlx5 updates 2023-12-20 Jakub Kicinski
2024-01-08 1:19 ` Jakub Kicinski
2024-01-08 23:14 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125184031.5ddc5799@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeed@kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).