From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Jiri Pirko <jiri@resnulli.us>,
Sabrina Dubroca <sd@queasysnail.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v6 1/4] netdevsim: allow two netdevsim ports to be connected
Date: Fri, 26 Jan 2024 11:17:44 -0800 [thread overview]
Message-ID: <20240126111744.7f2dd7a3@kernel.org> (raw)
In-Reply-To: <d1aae414-6225-4a1f-86dd-c185ebfa978f@davidwei.uk>
On Fri, 26 Jan 2024 10:54:35 -0800 David Wei wrote:
> > since you're under rtnl_lock you can use __get_device_by_index(),
> > it doesn't increase the refcount so you won't have to worry about
> > releasing it.
>
> Ah, I will change this. Is this true in general i.e. if I hold some big
> lock then I can use versions of functions that do not modify refcounts?
I don't think so, generally you can ignore refcounts if you're holding
the lock protecting the table in which the object is registered while
it is alive, and you just looked it up in that table... if that makes
sense.
netdev lifetime is a bit unusual in how much the rtnl_lock protects.
next prev parent reply other threads:[~2024-01-26 19:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 1:23 [PATCH net-next v6 0/4] netdevsim: link and forward skbs between ports David Wei
2024-01-26 1:23 ` [PATCH net-next v6 1/4] netdevsim: allow two netdevsim ports to be connected David Wei
2024-01-26 2:24 ` Jakub Kicinski
2024-01-26 18:54 ` David Wei
2024-01-26 19:17 ` Jakub Kicinski [this message]
2024-01-26 1:23 ` [PATCH net-next v6 2/4] netdevsim: forward skbs from one connected port to another David Wei
2024-01-26 2:26 ` Jakub Kicinski
2024-01-26 18:55 ` David Wei
2024-01-26 1:23 ` [PATCH net-next v6 3/4] netdevsim: add selftest for forwarding skb between connected ports David Wei
2024-01-26 1:23 ` [PATCH net-next v6 4/4] netdevsim: add Makefile for selftests David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126111744.7f2dd7a3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).