netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] selftests: forwarding: Add missing config entries
Date: Fri, 26 Jan 2024 11:25:38 -0800	[thread overview]
Message-ID: <20240126112538.2a4f8710@kernel.org> (raw)
In-Reply-To: <025abded7ff9cea5874a7fe35dcd3fd41bf5e6ac.1706286755.git.petrm@nvidia.com>

On Fri, 26 Jan 2024 17:36:16 +0100 Petr Machata wrote:
> The config file contains a partial kernel configuration to be used by
> `virtme-configkernel --custom'. The presumption is that the config file
> contains all Kconfig options needed by the selftests from the directory.
> 
> In net/forwarding/config, many are missing, which manifests as spurious
> failures when running the selftests, with messages about unknown device
> types, qdisc kinds or classifier actions. Add the missing configurations.
> 
> Tested the resulting configuration using virtme-ng as follows:
> 
>  # vng -b -f tools/testing/selftests/net/forwarding/config
>  # vng --user root
>  (within the VM:)
>  # make -C tools/testing/selftests TARGETS=net/forwarding run_tests

Thanks a lot for fixing this stuff! The patch went into the
net-next-2024-01-26--18-00 branch we got: pass 94 / skip 2 / fail 15

https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-01-26--18-00&executor=vmksft-forwarding&pw-y=0

Clicking thru a handful of the failures it looks like it's about a 50/50
split between timeouts and perf mismatch. 

BTW when it says: "WAIT TIMEOUT stdout" that means the runner got angry
because the test didn't print anything for 20 minutes. I'll bump this
timeout to an hour for the next branch, and lets see how many failures
we have left.

  reply	other threads:[~2024-01-26 19:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 16:36 [PATCH net-next] selftests: forwarding: Add missing config entries Petr Machata
2024-01-26 19:25 ` Jakub Kicinski [this message]
2024-01-29 10:45   ` Petr Machata
2024-01-30  2:31     ` Jakub Kicinski
2024-01-30 12:45 ` Paolo Abeni
2024-01-30 13:00 ` patchwork-bot+netdevbpf
2024-01-30 14:30 ` Jiri Pirko
2024-01-30 18:14   ` Jakub Kicinski
2024-02-13 17:17     ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240126112538.2a4f8710@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).