From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Shuah Khan <shuah@kernel.org>,
Xin Long <lucien.xin@gmail.com>, Florian Westphal <fw@strlen.de>,
Aaron Conole <aconole@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: net: add missing config for big tcp tests
Date: Fri, 26 Jan 2024 11:55:51 -0800 [thread overview]
Message-ID: <20240126115551.176e3888@kernel.org> (raw)
In-Reply-To: <21630ecea872fea13f071342ac64ef52a991a9b5.1706282943.git.pabeni@redhat.com>
On Fri, 26 Jan 2024 16:32:36 +0100 Paolo Abeni wrote:
> The big_tcp test-case requires a few kernel knobs currently
> not specified in the net selftests config, causing the
> following failure:
>
> # selftests: net: big_tcp.sh
> # Error: Failed to load TC action module.
> # We have an error talking to the kernel
> ...
> # Testing for BIG TCP:
> # CLI GSO | GW GRO | GW GSO | SER GRO
> # ./big_tcp.sh: line 107: test: !=: unary operator expected
> ...
> # on on on on : [FAIL_on_link1]
>
> Add the missing configs
>
> Fixes: 6bb382bcf742 ("selftests: add a selftest for big tcp")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Ah, great, I was missing RF_RAW in the local hack.
I applied manually because looks like this change is on top of
something:
patching file tools/testing/selftests/net/config
Hunk #3 succeeded at 73 with fuzz 1 (offset -1 lines).
Hunk #4 succeeded at 82 (offset -1 lines).
While at it I reordered the values a little bit to be closer to what
I think would get us closer to alphasort. Hope you don't mind.
next prev parent reply other threads:[~2024-01-26 19:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 15:32 [PATCH net] selftests: net: add missing config for big tcp tests Paolo Abeni
2024-01-26 16:18 ` Aaron Conole
2024-01-26 16:55 ` Paolo Abeni
2024-01-26 16:43 ` Xin Long
2024-01-26 19:55 ` Jakub Kicinski [this message]
2024-01-29 9:11 ` Paolo Abeni
2024-01-29 16:31 ` Paolo Abeni
2024-01-29 16:39 ` Jakub Kicinski
2024-01-30 18:41 ` Paolo Abeni
2024-01-31 1:18 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126115551.176e3888@kernel.org \
--to=kuba@kernel.org \
--cc=aconole@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=linux-kselftest@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).