From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 4/6] ethtool: add suffix _u32 to legacy bitmap members of struct ethtool_keee
Date: Fri, 26 Jan 2024 21:20:40 -0800 [thread overview]
Message-ID: <20240126212040.0fe28d88@kernel.org> (raw)
In-Reply-To: <e6ec45ea-0bfe-48f5-8169-a34e070732cb@gmail.com>
On Fri, 26 Jan 2024 23:15:33 +0100 Heiner Kallweit wrote:
> This is in preparation of using the existing names for linkmode
> bitmaps.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
missed some?
drivers/net/ethernet/aquantia/atlantic/aq_ethtool.c:719:30: error: no member named 'supported' in 'struct ethtool_keee'
719 | eee->advertised_u32 = eee->supported;
| ~~~ ^
--
pw-bot: cr
next prev parent reply other threads:[~2024-01-27 5:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 22:11 [PATCH net-next v3 0/6] ethtool: switch EEE netlink interface to use EEE linkmode bitmaps Heiner Kallweit
2024-01-26 22:12 ` [PATCH net-next v3 1/6] ethtool: replace struct ethtool_eee with a new struct ethtool_keee on kernel side Heiner Kallweit
2024-01-26 22:13 ` [PATCH net-next v3 2/6] ethtool: switch back from ethtool_keee to ethtool_eee for ioctl Heiner Kallweit
2024-01-26 22:14 ` [PATCH net-next v3 3/6] ethtool: adjust struct ethtool_keee to kernel needs Heiner Kallweit
2024-01-26 22:15 ` [PATCH net-next v3 4/6] ethtool: add suffix _u32 to legacy bitmap members of struct ethtool_keee Heiner Kallweit
2024-01-27 5:20 ` Jakub Kicinski [this message]
2024-01-27 13:21 ` Heiner Kallweit
2024-01-26 22:16 ` [PATCH net-next v3 5/6] ethtool: add linkmode bitmap support to " Heiner Kallweit
2024-01-26 22:17 ` [PATCH net-next v3 6/6] net: phy: c45: change genphy_c45_ethtool_[get|set]_eee to use EEE linkmode bitmaps Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240126212040.0fe28d88@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).