netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Petr Machata <petrm@nvidia.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	netdev@vger.kernel.org, Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net-next] selftests: forwarding: Add missing config entries
Date: Tue, 30 Jan 2024 10:14:23 -0800	[thread overview]
Message-ID: <20240130101423.45b0e1c1@kernel.org> (raw)
In-Reply-To: <ZbkIFrruZO5DXODm@nanopsycho>

On Tue, 30 Jan 2024 15:30:46 +0100 Jiri Pirko wrote:
> For me, all tests end up with:
> SKIP: Cannot create interface. Name not specified
> 
> Do I miss some config file? If yes, can't we have some default testing
> ifnames in case the config is not there?

Thanks for bringing this up... I forgot to

  cp forwarding.config.sample forwarding.config

an embarrassing number of times. +1 for printing a warning and using
the sample if forwarding.config does not exist.

  reply	other threads:[~2024-01-30 18:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-26 16:36 [PATCH net-next] selftests: forwarding: Add missing config entries Petr Machata
2024-01-26 19:25 ` Jakub Kicinski
2024-01-29 10:45   ` Petr Machata
2024-01-30  2:31     ` Jakub Kicinski
2024-01-30 12:45 ` Paolo Abeni
2024-01-30 13:00 ` patchwork-bot+netdevbpf
2024-01-30 14:30 ` Jiri Pirko
2024-01-30 18:14   ` Jakub Kicinski [this message]
2024-02-13 17:17     ` Petr Machata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240130101423.45b0e1c1@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=idosch@idosch.org \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).