From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "Mina Almasry" <almasrymina@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jason Gunthorpe" <jgg@nvidia.com>,
"Christian König" <christian.koenig@amd.com>,
"Shakeel Butt" <shakeelb@google.com>,
"Yunsheng Lin" <linyunsheng@huawei.com>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCH net-next v6 1/2] net: introduce abstraction for network memory
Date: Tue, 30 Jan 2024 16:47:06 -0800 [thread overview]
Message-ID: <20240130164706.6eb6a9b3@kernel.org> (raw)
In-Reply-To: <0c767128a7ceee72c3cfb4c17498ef3b6fd87a56.camel@redhat.com>
On Tue, 30 Jan 2024 10:59:53 +0100 Paolo Abeni wrote:
> > + * netmem_ref - a nonexistent type marking a reference to generic network
>
> Minor nit: here you need to prepend 'struct' to avoid a kdoc warning:
>
> include/net/netmem.h:20: warning: cannot understand function prototype: 'typedef unsigned long __bitwise netmem_ref; '
>
> Should be:
>
> * struct netmem_ref - a nonexistent type marking a reference to generic network
s/struct/typedef/
/**
* typedef netmem_ref - ....
*/
Somewhat surprisingly kdoc understands the typedef keyword just fine :)
next prev parent reply other threads:[~2024-01-31 0:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 22:17 [PATCH net-next v6 0/2] Abstract page from net stack Mina Almasry
2024-01-23 22:17 ` [PATCH net-next v6 1/2] net: introduce abstraction for network memory Mina Almasry
2024-01-30 9:59 ` Paolo Abeni
2024-01-31 0:47 ` Jakub Kicinski [this message]
2024-01-23 22:17 ` [PATCH net-next v6 2/2] net: add netmem to skb_frag_t Mina Almasry
2024-01-30 9:33 ` Paolo Abeni
2024-02-01 20:45 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130164706.6eb6a9b3@kernel.org \
--to=kuba@kernel.org \
--cc=almasrymina@google.com \
--cc=christian.koenig@amd.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shakeelb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).