[PATCH net-next] selftests: net: Add missing matchall classifier

[PATCH net-next] selftests: net: Add missing matchall classifier

[Ido Schimmel]

One of the test cases in the test_bridge_backup_port.sh selftest relies
on a matchall classifier to drop unrelated traffic so that the Tx drop
counter on the VXLAN device will only be incremented as a result of
traffic generated by the test.

However, the configuration option for the matchall classifier is
missing from the configuration file which might explain the failures we
see in the netdev CI [1].

Fix by adding CONFIG_NET_CLS_MATCHALL to the configuration file.

[1]
 # Backup nexthop ID - invalid IDs
 # -------------------------------
 [...]
 # TEST: Forwarding out of vx0                                         [ OK ]
 # TEST: No forwarding using backup nexthop ID                         [ OK ]
 # TEST: Tx drop increased                                             [FAIL]
 # TEST: IPv6 address family nexthop as backup nexthop                 [ OK ]
 # TEST: No forwarding out of swp1                                     [ OK ]
 # TEST: Forwarding out of vx0                                         [ OK ]
 # TEST: No forwarding using backup nexthop ID                         [ OK ]
 # TEST: Tx drop increased                                             [FAIL]
 [...]

Fixes: b408453053fb ("selftests: net: Add bridge backup port and backup nexthop ID test")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
Jakub, you can apply to net if you want to, but I'm sending this to
net-next since I want to see if it helps the CI. I'm unable to reproduce
this locally.
---
 tools/testing/selftests/net/config | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
index 19ff75051660..2bd5f9033ade 100644
--- a/tools/testing/selftests/net/config
+++ b/tools/testing/selftests/net/config
@@ -68,6 +68,7 @@ CONFIG_MPLS_ROUTING=m
 CONFIG_MPLS_IPTUNNEL=m
 CONFIG_NET_SCH_INGRESS=m
 CONFIG_NET_CLS_FLOWER=m
+CONFIG_NET_CLS_MATCHALL=m
 CONFIG_NET_ACT_TUNNEL_KEY=m
 CONFIG_NET_ACT_MIRRED=m
 CONFIG_BAREUDP=m
-- 
2.43.0

Re: [PATCH net-next] selftests: net: Add missing matchall classifier

[Nikolay Aleksandrov]

On 29/01/2024 14:37, Ido Schimmel wrote:
> One of the test cases in the test_bridge_backup_port.sh selftest relies
> on a matchall classifier to drop unrelated traffic so that the Tx drop
> counter on the VXLAN device will only be incremented as a result of
> traffic generated by the test.
> 
> However, the configuration option for the matchall classifier is
> missing from the configuration file which might explain the failures we
> see in the netdev CI [1].
> 
> Fix by adding CONFIG_NET_CLS_MATCHALL to the configuration file.
> 
> [1]
>  # Backup nexthop ID - invalid IDs
>  # -------------------------------
>  [...]
>  # TEST: Forwarding out of vx0                                         [ OK ]
>  # TEST: No forwarding using backup nexthop ID                         [ OK ]
>  # TEST: Tx drop increased                                             [FAIL]
>  # TEST: IPv6 address family nexthop as backup nexthop                 [ OK ]
>  # TEST: No forwarding out of swp1                                     [ OK ]
>  # TEST: Forwarding out of vx0                                         [ OK ]
>  # TEST: No forwarding using backup nexthop ID                         [ OK ]
>  # TEST: Tx drop increased                                             [FAIL]
>  [...]
> 
> Fixes: b408453053fb ("selftests: net: Add bridge backup port and backup nexthop ID test")
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> Jakub, you can apply to net if you want to, but I'm sending this to
> net-next since I want to see if it helps the CI. I'm unable to reproduce
> this locally.
> ---
>  tools/testing/selftests/net/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config
> index 19ff75051660..2bd5f9033ade 100644
> --- a/tools/testing/selftests/net/config
> +++ b/tools/testing/selftests/net/config
> @@ -68,6 +68,7 @@ CONFIG_MPLS_ROUTING=m
>  CONFIG_MPLS_IPTUNNEL=m
>  CONFIG_NET_SCH_INGRESS=m
>  CONFIG_NET_CLS_FLOWER=m
> +CONFIG_NET_CLS_MATCHALL=m
>  CONFIG_NET_ACT_TUNNEL_KEY=m
>  CONFIG_NET_ACT_MIRRED=m
>  CONFIG_BAREUDP=m

Thanks,
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>

Re: [PATCH net-next] selftests: net: Add missing matchall classifier

[Jakub Kicinski]

On Mon, 29 Jan 2024 14:37:03 +0200 Ido Schimmel wrote:
> One of the test cases in the test_bridge_backup_port.sh selftest relies
> on a matchall classifier to drop unrelated traffic so that the Tx drop
> counter on the VXLAN device will only be incremented as a result of
> traffic generated by the test.
> 
> However, the configuration option for the matchall classifier is
> missing from the configuration file which might explain the failures we
> see in the netdev CI [1].
> 
> Fix by adding CONFIG_NET_CLS_MATCHALL to the configuration file.

Moved to the larger group of NET_CLS knobs, and applied to net,
thank you!