From: Benjamin Poirier <bpoirier@nvidia.com>
To: netdev@vger.kernel.org
Cc: Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Shuah Khan <shuah@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Petr Machata <petrm@nvidia.com>,
Danielle Ratson <danieller@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>,
Johannes Nixdorf <jnixdorf-oss@avm.de>,
Davide Caratti <dcaratti@redhat.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Tobias Waldekranz <tobias@waldekranz.com>,
Coco Li <lixiaoyan@google.com>,
Willem de Bruijn <willemb@google.com>,
Lucas Karpinski <lkarpins@redhat.com>,
Anders Roxell <anders.roxell@linaro.org>,
Hangbin Liu <liuhangbin@gmail.com>,
linux-kselftest@vger.kernel.org
Subject: [PATCH net 4/5] selftests: net: List helper scripts in TEST_FILES Makefile variable
Date: Wed, 31 Jan 2024 09:08:47 -0500 [thread overview]
Message-ID: <20240131140848.360618-5-bpoirier@nvidia.com> (raw)
In-Reply-To: <20240131140848.360618-1-bpoirier@nvidia.com>
Some scripts are not tests themselves; they contain utility functions used
by other tests. According to Documentation/dev-tools/kselftest.rst, such
files should be listed in TEST_FILES. Move those utility scripts to
TEST_FILES.
Fixes: 1751eb42ddb5 ("selftests: net: use TEST_PROGS_EXTENDED")
Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
Fixes: b99ac1841147 ("kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile")
Fixes: f5173fe3e13b ("selftests: net: included needed helper in the install targets")
Suggested-by: Petr Machata <petrm@nvidia.com>
Signed-off-by: Benjamin Poirier <bpoirier@nvidia.com>
---
tools/testing/selftests/net/Makefile | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 48c6f93b8149..211753756bde 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -53,9 +53,7 @@ TEST_PROGS += bind_bhash.sh
TEST_PROGS += ip_local_port_range.sh
TEST_PROGS += rps_default_mask.sh
TEST_PROGS += big_tcp.sh
-TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
-TEST_PROGS_EXTENDED += toeplitz_client.sh toeplitz.sh lib.sh
-TEST_PROGS_EXTENDED += net_helper.sh
+TEST_PROGS_EXTENDED := toeplitz_client.sh toeplitz.sh
TEST_GEN_FILES = socket nettest
TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
@@ -97,6 +95,7 @@ TEST_PROGS += fq_band_pktlimit.sh
TEST_PROGS += vlan_hw_filter.sh
TEST_FILES := settings
+TEST_FILES += in_netns.sh lib.sh net_helper.sh setup_loopback.sh setup_veth.sh
include ../lib.mk
--
2.43.0
next prev parent reply other threads:[~2024-01-31 14:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 14:08 [PATCH net 0/5] selftests: net: More small fixes Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 1/5] selftests: team: Add missing config options Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 2/5] selftests: bonding: Check initial state Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 3/5] selftests: net: Remove executable bits from library scripts Benjamin Poirier
2024-01-31 14:08 ` Benjamin Poirier [this message]
2024-01-31 14:08 ` [PATCH net 5/5] selftests: forwarding: List helper scripts in TEST_FILES Makefile variable Benjamin Poirier
2024-01-31 20:20 ` [PATCH net 0/5] selftests: net: More small fixes patchwork-bot+netdevbpf
2024-02-01 1:15 ` Jakub Kicinski
2024-02-01 16:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131140848.360618-5-bpoirier@nvidia.com \
--to=bpoirier@nvidia.com \
--cc=anders.roxell@linaro.org \
--cc=andy@greyhouse.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=j.vosburgh@gmail.com \
--cc=jiri@resnulli.us \
--cc=jnixdorf-oss@avm.de \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lixiaoyan@google.com \
--cc=lkarpins@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=tobias@waldekranz.com \
--cc=vladimir.oltean@nxp.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).