netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Benjamin Poirier <bpoirier@nvidia.com>
Cc: netdev@vger.kernel.org, Jay Vosburgh <j.vosburgh@gmail.com>,
	Andy Gospodarek <andy@greyhouse.net>,
	Shuah Khan <shuah@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Petr Machata <petrm@nvidia.com>,
	Danielle Ratson <danieller@nvidia.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Johannes Nixdorf <jnixdorf-oss@avm.de>,
	Davide Caratti <dcaratti@redhat.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Tobias Waldekranz <tobias@waldekranz.com>,
	Coco Li <lixiaoyan@google.com>,
	Willem de Bruijn <willemb@google.com>,
	Lucas Karpinski <lkarpins@redhat.com>,
	Anders Roxell <anders.roxell@linaro.org>,
	Hangbin Liu <liuhangbin@gmail.com>,
	linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net 0/5] selftests: net: More small fixes
Date: Wed, 31 Jan 2024 17:15:13 -0800	[thread overview]
Message-ID: <20240131171513.20eece61@kernel.org> (raw)
In-Reply-To: <20240131140848.360618-1-bpoirier@nvidia.com>

On Wed, 31 Jan 2024 09:08:43 -0500 Benjamin Poirier wrote:
> Some small fixes for net selftests which follow from these recent commits:
> dd2d40acdbb2 ("selftests: bonding: Add more missing config options")
> 49078c1b80b6 ("selftests: forwarding: Remove executable bits from lib.sh")

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Not so great that the team test was passing even tho it lacks 
so many configs...

TAP version 13
1..1
# timeout set to 45
# selftests: drivers/net/team: dev_addr_lists.sh
# Error: Unknown device type.
# Error: Unknown device type.
# This program is not intended to be run as root.
[   17.601119] team0: Mode changed to "loadbalance"
# RTNETLINK answers: Operation not supported
# TEST: team cleanup mode lacp                                        [ OK ]
ok 1 selftests: drivers/net/team: dev_addr_lists.sh

:(

  parent reply	other threads:[~2024-02-01  1:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 14:08 [PATCH net 0/5] selftests: net: More small fixes Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 1/5] selftests: team: Add missing config options Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 2/5] selftests: bonding: Check initial state Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 3/5] selftests: net: Remove executable bits from library scripts Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 4/5] selftests: net: List helper scripts in TEST_FILES Makefile variable Benjamin Poirier
2024-01-31 14:08 ` [PATCH net 5/5] selftests: forwarding: " Benjamin Poirier
2024-01-31 20:20 ` [PATCH net 0/5] selftests: net: More small fixes patchwork-bot+netdevbpf
2024-02-01  1:15 ` Jakub Kicinski [this message]
2024-02-01 16:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240131171513.20eece61@kernel.org \
    --to=kuba@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=andy@greyhouse.net \
    --cc=bpoirier@nvidia.com \
    --cc=danieller@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=edumazet@google.com \
    --cc=idosch@nvidia.com \
    --cc=j.vosburgh@gmail.com \
    --cc=jiri@resnulli.us \
    --cc=jnixdorf-oss@avm.de \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=liuhangbin@gmail.com \
    --cc=lixiaoyan@google.com \
    --cc=lkarpins@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=petrm@nvidia.com \
    --cc=shuah@kernel.org \
    --cc=tobias@waldekranz.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).