public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Chris Leech <cleech@redhat.com>
Cc: Nilesh Javali <njavali@marvell.com>,
	Christoph Hellwig <hch@lst.de>,
	John Meneghini <jmeneghi@redhat.com>,
	Lee Duncan <lduncan@suse.com>,
	Mike Christie <michael.christie@oracle.com>,
	Hannes Reinecke <hare@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org,
	GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 2/2] cnic,bnx2,bnx2x: use UIO_MEM_DMA_COHERENT
Date: Wed, 31 Jan 2024 13:29:56 -0800	[thread overview]
Message-ID: <2024013125-unraveled-definite-7fc6@gregkh> (raw)
In-Reply-To: <20240131191732.3247996-3-cleech@redhat.com>

On Wed, Jan 31, 2024 at 11:17:32AM -0800, Chris Leech wrote:
> Use the UIO_MEM_DMA_COHERENT type to properly handle mmap for
> dma_alloc_coherent buffers.
> 
> The cnic l2_ring and l2_buf mmaps have caused page refcount issues as
> the dma_alloc_coherent no longer provide __GFP_COMP allocation as per
> commit "dma-mapping: reject __GFP_COMP in dma_alloc_attrs".
> 
> Fix this by having the uio device use dma_mmap_coherent.
> 
> The bnx2 and bnx2x status block allocations are also dma_alloc_coherent,
> and should use dma_mmap_coherent. They don't allocate multiple pages,
> but this interface does not work correctly with an iommu enabled unless
> dma_mmap_coherent is used.
> 
> Fixes: bb73955c0b1d ("cnic: don't pass bogus GFP_ flags to dma_alloc_coherent")

This is really the commit that broke things?  By adding this, are you
expecting anyone to backport this change to older kernels?

thanks,

greg k-h

  reply	other threads:[~2024-01-31 21:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 19:17 [PATCH 0/2] UIO_MEM_DMA_COHERENT for cnic/bnx2/bnx2x Chris Leech
2024-01-31 19:17 ` [PATCH 1/2] uio: introduce UIO_MEM_DMA_COHERENT type Chris Leech
2024-01-31 21:28   ` Greg Kroah-Hartman
2024-01-31 21:44     ` Chris Leech
2024-02-01  4:44       ` Christoph Hellwig
2024-02-01  4:46   ` Christoph Hellwig
2024-02-01 15:03     ` Greg Kroah-Hartman
2024-03-12  8:40   ` Thomas Weißschuh
2024-01-31 19:17 ` [PATCH 2/2] cnic,bnx2,bnx2x: use UIO_MEM_DMA_COHERENT Chris Leech
2024-01-31 21:29   ` Greg Kroah-Hartman [this message]
2024-01-31 21:46     ` Chris Leech
2024-02-01  4:45     ` Christoph Hellwig
2024-01-31 21:27 ` [PATCH 0/2] UIO_MEM_DMA_COHERENT for cnic/bnx2/bnx2x Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024013125-unraveled-definite-7fc6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=cleech@redhat.com \
    --cc=hare@kernel.org \
    --cc=hch@lst.de \
    --cc=jmeneghi@redhat.com \
    --cc=lduncan@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michael.christie@oracle.com \
    --cc=netdev@vger.kernel.org \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox