netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 3/3] net/sched: netem: update intro comment
Date: Wed, 31 Jan 2024 19:46:00 -0800	[thread overview]
Message-ID: <20240201034653.450138-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20240201034653.450138-1-stephen@networkplumber.org>

Netem originally used a nested qdisc to handle rate limiting,
but that has been replaced (for many years) with an internal FIFO.
Update the intro comment to reflect this.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 net/sched/sch_netem.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c
index f712d03ad854..cc3df77503b3 100644
--- a/net/sched/sch_netem.c
+++ b/net/sched/sch_netem.c
@@ -44,9 +44,8 @@
 	 duplication, and reordering can also be emulated.
 
 	 This qdisc does not do classification that can be handled in
-	 layering other disciplines.  It does not need to do bandwidth
-	 control either since that can be handled by using token
-	 bucket or other rate control.
+	 layering other disciplines. Netem includes an optional internal
+	 rate limiter (tfifo) based on next time to send.
 
      Correlated Loss Generator models
 
-- 
2.43.0


  parent reply	other threads:[~2024-02-01  3:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-01  3:45 [PATCH 0/3] net/sched: netem cleanups Stephen Hemminger
2024-02-01  3:45 ` [PATCH 1/3] net/sched: netem: use extack Stephen Hemminger
2024-02-01  9:30   ` Jiri Pirko
2024-02-01 17:00     ` Jakub Kicinski
2024-02-02 11:53       ` Donald Hunter
2024-02-02 16:23         ` Jakub Kicinski
2024-02-02 17:03           ` Donald Hunter
2024-02-01  3:45 ` [PATCH 2/3] net/sched: netem: get rid of unnecesary version message Stephen Hemminger
2024-02-01  9:31   ` Jiri Pirko
2024-02-01  3:46 ` Stephen Hemminger [this message]
2024-02-01  9:32   ` [PATCH 3/3] net/sched: netem: update intro comment Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201034653.450138-4-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).