From: Christoph Hellwig <hch@lst.de>
To: Chris Leech <cleech@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nilesh Javali <njavali@marvell.com>,
Christoph Hellwig <hch@lst.de>,
John Meneghini <jmeneghi@redhat.com>,
Lee Duncan <lduncan@suse.com>,
Mike Christie <michael.christie@oracle.com>,
Hannes Reinecke <hare@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org,
GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 1/2] uio: introduce UIO_MEM_DMA_COHERENT type
Date: Thu, 1 Feb 2024 05:44:16 +0100 [thread overview]
Message-ID: <20240201044416.GA14176@lst.de> (raw)
In-Reply-To: <CAPnfmX+c_TECfVgbAgphFgkCOr-=tKEvHmcxPg_vSY-qJRqaQQ@mail.gmail.com>
On Wed, Jan 31, 2024 at 01:44:50PM -0800, Chris Leech wrote:
> On Wed, Jan 31, 2024 at 1:29 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Jan 31, 2024 at 11:17:31AM -0800, Chris Leech wrote:
> > > Add a UIO memtype specifically for sharing dma_alloc_coherent
> > > memory with userspace, backed by dma_mmap_coherent.
> > >
> > > This is mainly for the bnx2/bnx2x/bnx2i "cnic" interface, although there
> > > are a few other uio drivers which map dma_alloc_coherent memory and
> > > could be converted to use dma_mmap_coherent as well.
> >
> > What other drivers could use this? Patches doing the conversion would
> > be welcome, otherwise, again, I am very loath to take this
> > one-off-change for just a single driver that shouldn't be doing this in
> > the first place :)
>
> uio_pruss and uio_dmem_genirq both appear to mmap dma_alloc_coherent
> memory as UIO_MEM_PHYS. It might not be an issue on that platforms
> where those are used, but I'd be happy to include untested patches to
> convert them for better adherence to the DMA APIs.
Yes, they do need fixing.
next prev parent reply other threads:[~2024-02-01 4:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 19:17 [PATCH 0/2] UIO_MEM_DMA_COHERENT for cnic/bnx2/bnx2x Chris Leech
2024-01-31 19:17 ` [PATCH 1/2] uio: introduce UIO_MEM_DMA_COHERENT type Chris Leech
2024-01-31 21:28 ` Greg Kroah-Hartman
2024-01-31 21:44 ` Chris Leech
2024-02-01 4:44 ` Christoph Hellwig [this message]
2024-02-01 4:46 ` Christoph Hellwig
2024-02-01 15:03 ` Greg Kroah-Hartman
2024-03-12 8:40 ` Thomas Weißschuh
2024-01-31 19:17 ` [PATCH 2/2] cnic,bnx2,bnx2x: use UIO_MEM_DMA_COHERENT Chris Leech
2024-01-31 21:29 ` Greg Kroah-Hartman
2024-01-31 21:46 ` Chris Leech
2024-02-01 4:45 ` Christoph Hellwig
2024-01-31 21:27 ` [PATCH 0/2] UIO_MEM_DMA_COHERENT for cnic/bnx2/bnx2x Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201044416.GA14176@lst.de \
--to=hch@lst.de \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=cleech@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=lduncan@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).