From: Jakub Kicinski <kuba@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
Andrew Morton <akpm@linux-foundation.org>,
Mahesh Bandewar <maheshb@google.com>,
weiwan@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, horms@kernel.org, andrew@lunn.ch,
leit@fb.com
Subject: Re: [PATCH] blackhole_dev: Fix buil warning
Date: Thu, 1 Feb 2024 11:40:59 -0800 [thread overview]
Message-ID: <20240201114059.50b1051c@kernel.org> (raw)
In-Reply-To: <Zbvm8HhzdHGXzlus@gmail.com>
On Thu, 1 Feb 2024 10:46:08 -0800 Breno Leitao wrote:
> > Since Jiri suggested a title fix I reckon we should be a bit more
> > specific, still. Imagine this title ending up in a quote or a Fixes
> > tag, could be many things.. How about:
> >
> > net: blackhole_dev: fix build warning for ethh set but not used
>
> Sure, let me resend it.
>
> I suppose I should recent to `net` given it is a building warning,
> right?
Not necessarily, net-next is good enough for W=1 warnings in general.
Compiler warnings only show up if the file in question or some header
it includes was modified. The linker warnings are a bit special.
If you touch any file in any module you'll see all linker warnings.
prev parent reply other threads:[~2024-02-01 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 13:32 [PATCH] blackhole_dev: Fix buil warning Breno Leitao
2024-02-01 16:02 ` Jiri Pirko
2024-02-01 16:55 ` Jakub Kicinski
2024-02-01 18:46 ` Breno Leitao
2024-02-01 19:40 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201114059.50b1051c@kernel.org \
--to=kuba@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=leit@fb.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).