From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BB5F3CF74 for ; Thu, 1 Feb 2024 21:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706823673; cv=none; b=dTCdjN2cvnn/f6z0FN1oNOyuP+WNc4UdZ/3hubJPzX3tlqk5yOBPOTjQ4wsqAoGowz4sKItlCBjjKZFbfppD+/q5nGpAVDSXydajBsHiwzaQodgiqqolsVyC4RSbC48gcK4Rag9TzSv9+92HLJsEKSebGdYa/v9aZ+GzPmDAtys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706823673; c=relaxed/simple; bh=g7SXkoeTW2KA52Kwf9BHGDyeXrMxWbrAYz1LhW9b6ns=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hum0y7o5aGpL4oAWeJJed4sncGQIEm3RMAByaHFUQ9ko/WFs8IaH8Sh61li/4PpMydZu9z9goFvEMQSmtCRaXvKX6NTf45d0p3nfQ6oJ5aMcUSpFJHDfaCkPwzlBZ1xhA/cnGa9ejOZXbkCFceSSKRNNWIBsOmlWcW+Y2Fskwbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bk0L1jb6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bk0L1jb6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EF5BC433F1; Thu, 1 Feb 2024 21:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706823672; bh=g7SXkoeTW2KA52Kwf9BHGDyeXrMxWbrAYz1LhW9b6ns=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bk0L1jb6cVkci1dyvLPG7juZwmwrGs+NRtLuHAFN5ceE/JyG1VJEpraKTK4Yo/vi5 JvUYiJ/aLECMohnRziWwPEP87SqrPt1Yu/HVAXLTCkUtoCij+l2hGvs3rV1um3BDf4 WRsnKHlBHQclA3AR0Q7ulOOvnYmFf6Usd1c+JOqKr56Yznq5zRjSfRs7pcbQE2rssR gWNlmhMFZ1WKlrA1x5rfD/QSlY2TFyb0ZTSPNOfbZBetLLIyM2+ga/QqZsKslvdBcL 1OsL+Ba6ndipYzaS7rwzwWfHiaJOq/EC0F1g4MMXfUVrd0fkZpRHagJWIMCzc3loKF KySdvBY3LE6iA== Date: Thu, 1 Feb 2024 13:41:08 -0800 From: Jakub Kicinski To: Eric Dumazet Cc: Paolo Abeni , "David S . Miller" , netdev@vger.kernel.org, eric.dumazet@gmail.com, syzbot , Jiri Pirko Subject: Re: [PATCH net] netdevsim: avoid potential loop in nsim_dev_trap_report_work() Message-ID: <20240201134108.195cf302@kernel.org> In-Reply-To: References: <20240201175324.3752746-1-edumazet@google.com> <9259d368c091b071d16bd1969240f4e9dffe92fb.camel@redhat.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 1 Feb 2024 21:10:46 +0100 Eric Dumazet wrote: > > And possibly adding 1ms delay there could be problematic? > > A conversion to schedule_delayed_work() would be needed I think. > > I looked at all syzbot reports and did not find > devlink_rel_nested_in_notify_work() in them, > I guess we were lucky all this time :) FWIW the devlink_rel_* stuff is for linecards and SIOV sub function instances, netdevsim can't fake those so syzbot probably never exercises that code :( Jiri is on CC, so we can consider him notified about the problem and leave it to him? :)