Re: [PATCH net-next v5 09/11] net: dsa: realtek: migrate user_mii_bus setup to realtek-dsa

Luiz Angelo Daros de Luca
2024-02-05T22:43:47Z

> > +/**
> > + * rtl83xx_setup_user_mdio() - register the user mii bus driver
> > + * @ds: DSA switch associated with this user_mii_bus
> > + *
> > + * This function first gets and mdio node under the dev OF node, aborting
> > + * if missing. That mdio node describing an mdio bus is used to register a
> > + * new mdio bus.
>
> The description has the overall feel of "Family Guy - Peter narrates his life"
> (https://www.youtube.com/watch?v=zw8zUMjEW0I).

Hahaha. Yes it does.

> You could be a bit more succinct and say something like "Registers the
> MDIO bus for built-in Ethernet PHYs, and associates it with the
> mandatory 'mdio' child OF node of the switch".

Done. Thanks.

Regards,

Luiz