From: Jakub Kicinski <kuba@kernel.org>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: davem@davemloft.net, jiri@resnulli.us, ivecera@redhat.com,
netdev@vger.kernel.org, roopa@nvidia.com, razor@blackwall.org,
bridge@lists.linux.dev, rostedt@goodmis.org, mhiramat@kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 0/5] net: switchdev: Tracepoints
Date: Thu, 1 Feb 2024 20:44:59 -0800 [thread overview]
Message-ID: <20240201204459.60fea698@kernel.org> (raw)
In-Reply-To: <20240130201937.1897766-1-tobias@waldekranz.com>
On Tue, 30 Jan 2024 21:19:32 +0100 Tobias Waldekranz wrote:
> This series starts off (1-2/5) by creating stringifiers for common
> switchdev objects. This will primarily be used by the tracepoints for
> decoding switchdev notifications, but drivers could also make use of
> them to provide richer debug/error messages.
>
> Then follows two refactoring commits (3-4/5), with no (intended)
> functional changes:
>
> - 3/5: Wrap all replay callbacks in br_switchdev.c in a switchdev
> function to make it easy to trace all of these.
>
> - 4/5: Instead of using a different format for deferred items, reuse
> the existing notification structures when enqueuing. This lets
> us share a bit more code, and it unifies the data presented by
> the tracepoints.
>
> Finally, add the tracepoints.
Is there any risk with conflicting with the fixes which are getting
worked on in parallel? Sorry for not investigating myself, ENOTIME.
> v1 -> v2:
>
> - Fixup kernel-doc comment for switchdev_call_replay
>
> I know that there are still some warnings issued by checkpatch, but
> I'm not sure how to work around them, given the nature of the mapper
> macros. Please advise.
It's a known problem, don't worry about those.
next prev parent reply other threads:[~2024-02-02 4:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 20:19 [PATCH v2 net-next 0/5] net: switchdev: Tracepoints Tobias Waldekranz
2024-01-30 20:19 ` [PATCH v2 net-next 1/5] net: switchdev: Wrap enums in mapper macros Tobias Waldekranz
2024-01-30 20:19 ` [PATCH v2 net-next 2/5] net: switchdev: Add helpers to display switchdev objects as strings Tobias Waldekranz
2024-02-02 4:49 ` Jakub Kicinski
2024-02-02 7:48 ` Tobias Waldekranz
2024-02-02 18:34 ` Jakub Kicinski
2024-01-30 20:19 ` [PATCH v2 net-next 3/5] net: switchdev: Relay all replay messages through a central function Tobias Waldekranz
2024-01-30 20:19 ` [PATCH v2 net-next 4/5] net: switchdev: Prepare deferred notifications before enqueuing them Tobias Waldekranz
2024-01-30 20:19 ` [PATCH v2 net-next 5/5] net: switchdev: Add tracepoints Tobias Waldekranz
2024-02-02 4:44 ` Jakub Kicinski [this message]
2024-02-02 7:21 ` [PATCH v2 net-next 0/5] net: switchdev: Tracepoints Tobias Waldekranz
2024-02-02 18:32 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240201204459.60fea698@kernel.org \
--to=kuba@kernel.org \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).