From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Realtek linux nic maintainers <nic_swsd@realtek.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH RESUBMIT net-next] r8169: simplify EEE handling
Date: Fri, 2 Feb 2024 08:15:11 -0800 [thread overview]
Message-ID: <20240202081511.3d4374f4@kernel.org> (raw)
In-Reply-To: <7122d90b-cdfe-4733-bfad-45ce63f75536@gmail.com>
On Fri, 2 Feb 2024 17:06:10 +0100 Heiner Kallweit wrote:
> >> Alternative would be to change phy_advertise_supported(), but this may
> >> impact systems with PHY's with EEE flaws.
> >
> > If i remember correctly, there was some worry enabling EEE by default
> > could upset some low latency use cases, PTP accuracy etc. So lets
> > leave it as it is. Maybe a helper would be useful
> > phy_advertise_eee_all() with a comment about why it could be used.
> >
> Yes, I think that's the way to go.
> To minimize efforts I'd like to keep this patch here as it is, then I'll
> add the helper and change this place in r8169 to use the new helper.
Sorry for being slow - on top or as v2? :)
next prev parent reply other threads:[~2024-02-02 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 20:31 [PATCH RESUBMIT net-next] r8169: simplify EEE handling Heiner Kallweit
2024-02-02 0:16 ` Andrew Lunn
2024-02-02 6:55 ` Heiner Kallweit
2024-02-02 13:12 ` Andrew Lunn
2024-02-02 16:06 ` Heiner Kallweit
2024-02-02 16:15 ` Jakub Kicinski [this message]
2024-02-02 20:36 ` Heiner Kallweit
2024-02-03 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240202081511.3d4374f4@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).