From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6167B1482E3; Fri, 2 Feb 2024 17:38:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706895524; cv=none; b=jRKT5VASU/ZTCwc87vqRxNYDLGotxcx7zNtMSO3RRvUXul6KfWha0oxk3s8iLGItyQ3x4oNqb54Cw8am5+P0h1+MgRqz2LJT7TKYN/M8F6pv7dUdwhB1ECxSfsk97eQ27aLcUTKDg/4RrYsV8PdTXDJUfIa8PCcXifHG8iUbJ8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706895524; c=relaxed/simple; bh=MtA9noOhhDHQujelAYh9x5KIExwAKOsv6PyJ3fv7OXU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hg4djwl0Lae1hnXQKIVUKOnxgQmgAqPxP6fKi6kMw2mudA3EWtcflpe5ApU/ssk9Hr4OAkcQ4Wq2EiQqKyEFqdNM9clFEcjXp2OAgV3cis3I38RWfhWgi2TnNWeUWDK9/E3vOanNFSbsOl9Y0EzXI/SecO8Y0oABBJt17hcgcWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tOUMOcHM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tOUMOcHM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9074C433C7; Fri, 2 Feb 2024 17:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706895524; bh=MtA9noOhhDHQujelAYh9x5KIExwAKOsv6PyJ3fv7OXU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tOUMOcHMkqKvW1YwGGKHj0cRCbyPtjwS7O044Li1EvDSAJG4+iwTOexhBBekUfqIL JuJFsr5TDv9c/mvSEkSjirYXugW4DUcSHNr8dsgt563qpDgGHDw/Dgth/ViXW/duaD +ziv8CuhukYeOBprBIEt12GLz7t1rzOQ6Nev7zOaJgo3OjmNb1gUsm5WaY88zr9NvR xr8Hjhd3SD8G2dI9VtdKSZhmseEjukphr/ThLrQHSyAZ0RKAm4Ng4Ob5rTZHDyajUQ 9zzHwkkwQ6U/0qHzJ9S8rpGqaQB9tW6VBU5r6hUolzd1K//AP17TIJd8KABKVjy8/+ RFW4rS/Zg1ssA== Date: Fri, 2 Feb 2024 09:38:43 -0800 From: Jakub Kicinski To: Daniel Jurgens Cc: Jason Xing , "Michael S. Tsirkin" , "netdev@vger.kernel.org" , "jasowang@redhat.com" , "xuanzhuo@linux.alibaba.com" , "virtualization@lists.linux.dev" , "davem@davemloft.net" , "edumazet@google.com" , "abeni@redhat.com" , Parav Pandit Subject: Re: [PATCH net-next] virtio_net: Add TX stop and wake counters Message-ID: <20240202093843.0e7c29d4@kernel.org> In-Reply-To: References: <20240130142521.18593-1-danielj@nvidia.com> <20240130095645-mutt-send-email-mst@kernel.org> <20240130104107-mutt-send-email-mst@kernel.org> <20240130105246-mutt-send-email-mst@kernel.org> <20240201202106.25d6dc93@kernel.org> <20240202080126.72598eef@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 2 Feb 2024 16:46:28 +0000 Daniel Jurgens wrote: > > Daniel, I think this may be a good enough excuse to add per-queue stats to > > the netdev genl family, if you're up for that. LMK if you want more info, > > otherwise I guess ethtool -S is fine for now. > > For now, I would like to go with ethtool -S. But I can take on the > netdev level as a background task. Are you suggesting adding them to > rtnl_link_stats64? More like page pool stats. See d49010adae7376384