From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C94118E08 for ; Mon, 5 Feb 2024 11:13:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707131616; cv=none; b=FylCbi2WmmG4qEu/IXr2enVhAkLyD2MO8i0HkVFxI0FbCdqNn2+f27LQKido7OPb+2+PllyQK91NsfKDBbEA+RxjJ8fYw93HeFb+/wVyrfLEGfZelOXeG5dwiRJH3GhVyfvAiZ9M8E+0kpfzxqeCEDFRfVYmiQM+9v1dskfrCnY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707131616; c=relaxed/simple; bh=qiyJcgmXr99ZarDMYq7VLCkuujzBIzl3EqIkNIzXRhw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V0JXG5wYNQpFK9xHj5PXtGF9jiHBqQIuxHYEu5PoVctjbxPMiMIlqr+8M5MWzJTvH/f8W0cp1mxG2b+3MM40J+Yde5y43ZI/vUcr5hVPRw9iiW0F4wCk1BjKLJjP7vtcGqyMlUz0fmCFGc7FvI2HdiU1tIgWfqNO9rmEZtHWaVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sn8jNGpH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sn8jNGpH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D77B6C433C7; Mon, 5 Feb 2024 11:13:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707131616; bh=qiyJcgmXr99ZarDMYq7VLCkuujzBIzl3EqIkNIzXRhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sn8jNGpHH/MLlXJThUYm7xb917OyH2VY7m8M+bLEnFKBBiNHS8qFqbhsXjq59pcR9 NvrTIwhjXOLBN1yHFdzOdv/BW8KDn5Uu3TaQcJI+3gpSYN2i+GmGR8rpeuyHyOn1Xc mz87kxGDILwXHkhhFzneKT6NXnzCwvRdzl60lJH6GI7iUY7rXL+k2J8NCxJnmZQYOG SWC63lCXTpon7o10Qt3XnQ7tDkePAkaxSQSLi5y04roI88m7tu4bvfX4tQjoCbOqDS 1WAAoHcctsj/QHT5K3e5x6VPe2cNVym8R/iU9tNL+BDPtSrStCP0DpIeyWEK1EJ1L/ il8NId+MlPWEw== Date: Mon, 5 Feb 2024 11:13:32 +0000 From: Simon Horman To: Maciej Fijalkowski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, magnus.karlsson@intel.com Subject: Re: [PATCH iwl-net 1/2] i40e: avoid double calling i40e_pf_rxq_wait() Message-ID: <20240205111332.GH960600@kernel.org> References: <20240201154219.607338-1-maciej.fijalkowski@intel.com> <20240201154219.607338-2-maciej.fijalkowski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240201154219.607338-2-maciej.fijalkowski@intel.com> On Thu, Feb 01, 2024 at 04:42:18PM +0100, Maciej Fijalkowski wrote: > Currently, when interface is being brought down and > i40e_vsi_stop_rings() is called, i40e_pf_rxq_wait() is called two times, > which is wrong. To showcase this scenario, simplified call stack looks > as follows: > > i40e_vsi_stop_rings() > i40e_control wait rx_q() > i40e_control_rx_q() > i40e_pf_rxq_wait() > i40e_vsi_wait_queues_disabled() > i40e_pf_rxq_wait() // redundant call > > To fix this, let us s/i40e_control_wait_rx_q/i40e_control_rx_q within > i40e_vsi_stop_rings(). > > Fixes: 65662a8dcdd0 ("i40e: Fix logic of disabling queues") > Signed-off-by: Maciej Fijalkowski Reviewed-by: Simon Horman