From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
Marcin Szycik <marcin.szycik@linux.intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Yury Norov <yury.norov@gmail.com>,
Andy Shevchenko <andy@kernel.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
Alexander Potapenko <glider@google.com>,
Jiri Pirko <jiri@resnulli.us>, Ido Schimmel <idosch@nvidia.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
"Simon Horman" <horms@kernel.org>, <linux-btrfs@vger.kernel.org>,
<dm-devel@redhat.com>, <ntfs3@lists.linux.dev>,
<linux-s390@vger.kernel.org>, <intel-wired-lan@lists.osuosl.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v5 00/21] ice: add PFCP filter support
Date: Tue, 6 Feb 2024 07:37:59 -0800 [thread overview]
Message-ID: <20240206073759.4d948d1e@kernel.org> (raw)
In-Reply-To: <c90e7c78-47e9-46d0-a4e5-cb4aca737d11@intel.com>
On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote:
> > Add support for creating PFCP filters in switchdev mode. Add pfcp module
> > that allows to create a PFCP-type netdev. The netdev then can be passed to
> > tc when creating a filter to indicate that PFCP filter should be created.
>
> I believe folks agreed that bitmap_{read,write}() should stay inline,
> ping then?
It's probably fine, IMHO. I mean, I think we agree that the rarely used
inlines should not sit in a header included by half of the kernel (not
an exaggeration). But IMHO a better fix would be to move out whatever
cpumask.h xarray.h and other common headers depend on to a cut-down
version rather than making your helpers not inline.
So I think all we need for now is for people to ack the respective
patches? Looks like cio and ntfs and missing acks, so are some of
the bitops core patches.
next prev parent reply other threads:[~2024-02-06 15:38 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 12:21 [PATCH net-next v5 00/21] ice: add PFCP filter support Alexander Lobakin
2024-02-01 12:21 ` [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read,write}() Alexander Lobakin
2024-02-01 13:23 ` Arnd Bergmann
2024-02-01 13:45 ` Alexander Potapenko
2024-02-01 14:02 ` Arnd Bergmann
2024-02-28 16:10 ` Yury Norov
2024-02-01 15:49 ` Alexander Lobakin
2024-02-01 12:21 ` [PATCH net-next v5 02/21] lib/test_bitmap: add tests for bitmap_{read,write}() Alexander Lobakin
2024-02-28 16:13 ` Yury Norov
2024-02-01 12:21 ` [PATCH net-next v5 03/21] lib/test_bitmap: use pr_info() for non-error messages Alexander Lobakin
2024-02-28 16:16 ` Yury Norov
2024-02-01 12:21 ` [PATCH net-next v5 04/21] bitops: add missing prototype check Alexander Lobakin
2024-02-28 16:18 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 05/21] bitops: make BYTES_TO_BITS() treewide-available Alexander Lobakin
2024-02-28 16:20 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 06/21] bitops: let the compiler optimize {__,}assign_bit() Alexander Lobakin
2024-02-28 16:23 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 07/21] linkmode: convert linkmode_{test,set,clear,mod}_bit() to macros Alexander Lobakin
2024-02-28 16:24 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 08/21] s390/cio: rename bitmap_size() -> idset_bitmap_size() Alexander Lobakin
2024-02-26 17:13 ` Peter Oberparleiter
2024-02-01 12:22 ` [PATCH net-next v5 09/21] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64() Alexander Lobakin
2024-02-28 16:26 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 10/21] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits() Alexander Lobakin
2024-02-28 16:27 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 11/21] tools: move alignment-related macros to new <linux/align.h> Alexander Lobakin
2024-02-02 11:37 ` Przemek Kitszel
2024-02-28 16:28 ` Yury Norov
2024-02-28 16:29 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 12/21] bitmap: introduce generic optimized bitmap_size() Alexander Lobakin
2024-02-28 16:31 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 13/21] bitmap: make bitmap_{get,set}_value8() use bitmap_{read,write}() Alexander Lobakin
2024-02-02 11:39 ` Przemek Kitszel
2024-02-28 16:31 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 14/21] lib/bitmap: add compile-time test for __assign_bit() optimization Alexander Lobakin
2024-02-28 16:32 ` Yury Norov
2024-02-01 12:22 ` [PATCH net-next v5 15/21] ip_tunnel: use a separate struct to store tunnel params in the kernel Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 16/21] ip_tunnel: convert __be16 tunnel flags to bitmaps Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 17/21] lib/bitmap: add tests for IP tunnel flags conversion helpers Alexander Lobakin
2024-02-28 16:38 ` Yury Norov
2024-03-26 12:20 ` Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 18/21] pfcp: add PFCP module Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 19/21] pfcp: always set pfcp metadata Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 20/21] ice: refactor ICE_TC_FLWR_FIELD_ENC_OPTS Alexander Lobakin
2024-02-01 12:22 ` [PATCH net-next v5 21/21] ice: Add support for PFCP hardware offload in switchdev Alexander Lobakin
2024-02-06 12:46 ` [PATCH net-next v5 00/21] ice: add PFCP filter support Alexander Lobakin
2024-02-06 15:37 ` Jakub Kicinski [this message]
2024-02-07 15:05 ` Jakub Kicinski
2024-02-12 11:35 ` [Intel-wired-lan] " Alexander Lobakin
2024-02-28 16:46 ` Yury Norov
2024-04-02 10:59 ` Niklas Schnelle
2024-04-02 11:00 ` Alexander Lobakin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206073759.4d948d1e@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andy@kernel.org \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jiri@resnulli.us \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=marcin.szycik@linux.intel.com \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=wojciech.drewek@intel.com \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).