From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E85BD12E1D8; Tue, 6 Feb 2024 15:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707233882; cv=none; b=L0pf7IqIZTVxRQEnyfe8oVZbqZVrP+nVaX+tkKsJHmlZHJiN+cnyja0YGriSeG9bT7GN9zmuVJCqokWBl8rRStrTFrNQuT9NmjlDWWeqWHxh9aji1/6LhOzdTPrd10D0nr7XfFomSETeX7tsZ5RTFEJHei3Tj+Pv1rFE+GQeqLc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707233882; c=relaxed/simple; bh=GS8UEbSCgKgB/gRexnGVpyWM7USUW2+rfEyDI5KxFn4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=aKLm59GU8SdbTf3YMKNINZjHWhgTThmPPAisGqJx1tE+tp7w3SXcmbn2Q6kEjm1JhD/Ws/76GY+CjQx7C5L0jgI7x1rLDR98qxUx9eGq4jt1cVngQOI4WH8gmw4TSNqKQ/GqaeqYd+2xPAvQGgzN+TsNAmlEspufas8ogxuctvc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MeC0/nmp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MeC0/nmp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 70DB0C433F1; Tue, 6 Feb 2024 15:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707233881; bh=GS8UEbSCgKgB/gRexnGVpyWM7USUW2+rfEyDI5KxFn4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MeC0/nmpBcpRMXw4qehV9ITDmznAf7JstSxhzuhPvmSPmjuZdqbsqo9BNmRWeWoWd o6eg1wrNN0GLFHvCP4CrxHM1IUwHDsbtV2bixepEFmxUcEkfWDFOuQWczE7xxRSG3e fkjZ9WfXNGazSJn3AhGHp8LkWiNAfqf0MISuAAroSLY8+e2CMIL38rjyPOIA1Hr4af I/WAm6tx7tx/or2mxg+UxmdYJA41uax1G65P1WiukM+x0qx0inmSelMJJaw8HwkCgk pf5HGsj/y9OPoA+7/Isz2zUwgz2b/aQ3J1pOh51tJl+5J6UnLmIkqdM6dBb6L22Lkb A9JQU7chc1uxw== Date: Tue, 6 Feb 2024 07:37:59 -0800 From: Jakub Kicinski To: Alexander Lobakin Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Michal Swiatkowski , Marcin Szycik , Wojciech Drewek , Yury Norov , Andy Shevchenko , "Rasmus Villemoes" , Alexander Potapenko , Jiri Pirko , Ido Schimmel , Przemek Kitszel , "Simon Horman" , , , , , , , Subject: Re: [PATCH net-next v5 00/21] ice: add PFCP filter support Message-ID: <20240206073759.4d948d1e@kernel.org> In-Reply-To: References: <20240201122216.2634007-1-aleksander.lobakin@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote: > > Add support for creating PFCP filters in switchdev mode. Add pfcp module > > that allows to create a PFCP-type netdev. The netdev then can be passed to > > tc when creating a filter to indicate that PFCP filter should be created. > > I believe folks agreed that bitmap_{read,write}() should stay inline, > ping then? It's probably fine, IMHO. I mean, I think we agree that the rarely used inlines should not sit in a header included by half of the kernel (not an exaggeration). But IMHO a better fix would be to move out whatever cpumask.h xarray.h and other common headers depend on to a cut-down version rather than making your helpers not inline. So I think all we need for now is for people to ack the respective patches? Looks like cio and ntfs and missing acks, so are some of the bitops core patches.