From: Jakub Kicinski <kuba@kernel.org>
To: "Keller, Jacob E" <jacob.e.keller@intel.com>
Cc: "Brady, Alan" <alan.brady@intel.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"willemdebruijn.kernel@gmail.com"
<willemdebruijn.kernel@gmail.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
"Bagnucki, Igor" <igor.bagnucki@intel.com>,
"Lobakin, Aleksander" <aleksander.lobakin@intel.com>
Subject: Re: [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages
Date: Tue, 6 Feb 2024 15:17:33 -0800 [thread overview]
Message-ID: <20240206151733.076ddfcd@kernel.org> (raw)
In-Reply-To: <CO1PR11MB508916E50B5BA5A85BE28852D6462@CO1PR11MB5089.namprd11.prod.outlook.com>
On Tue, 6 Feb 2024 22:50:25 +0000 Keller, Jacob E wrote:
> > Hm, okay, that does sound like making it worse.
> > I'll disable the minmax coccicheck for now, it seems noisy.
>
> Maybe you could make the coccicheck only complain if the value is
> non-zero or not const? Maybe that's a bit too complicated... Hm
Non-zero could work. It may be worthwhile to look at the warnings cocci
currently generates and figure out what's common among the cases where
warning doesn't make sense.
prev parent reply other threads:[~2024-02-06 23:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 3:37 [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages Alan Brady
2024-02-06 3:37 ` [PATCH v4 01/10 iwl-next] idpf: implement virtchnl transaction manager Alan Brady
2024-02-20 14:30 ` Alexander Lobakin
2024-02-20 16:23 ` Alan Brady
2024-02-06 3:37 ` [PATCH v4 02/10 iwl-next] idpf: refactor vport virtchnl messages Alan Brady
2024-02-06 3:37 ` [PATCH v4 03/10 iwl-next] idpf: refactor queue related " Alan Brady
2024-02-06 3:37 ` [PATCH v4 04/10 iwl-next] idpf: refactor remaining " Alan Brady
2024-02-06 3:37 ` [PATCH v4 05/10 iwl-next] idpf: add async_handler for MAC filter messages Alan Brady
2024-02-06 3:38 ` [PATCH v4 06/10 iwl-next] idpf: refactor idpf_recv_mb_msg Alan Brady
2024-02-06 3:38 ` [PATCH v4 07/10 iwl-next] idpf: cleanup virtchnl cruft Alan Brady
2024-02-06 3:38 ` [PATCH v4 08/10 iwl-next] idpf: prevent deinit uninitialized virtchnl core Alan Brady
2024-02-06 3:38 ` [PATCH v4 09/10 iwl-next] idpf: fix minor controlq issues Alan Brady
2024-02-06 3:38 ` [PATCH v4 10/10 iwl-next] idpf: remove dealloc vector msg err in idpf_intr_rel Alan Brady
2024-02-06 17:02 ` [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages Alexander Lobakin
2024-02-14 14:49 ` Alexander Lobakin
2024-02-14 17:06 ` Alan Brady
2024-02-20 13:47 ` [Intel-wired-lan] " Alexander Lobakin
2024-02-06 18:57 ` Jakub Kicinski
2024-02-06 19:18 ` Alan Brady
2024-02-06 20:03 ` Jakub Kicinski
2024-02-06 22:50 ` Keller, Jacob E
2024-02-06 23:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206151733.076ddfcd@kernel.org \
--to=kuba@kernel.org \
--cc=alan.brady@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=igor.bagnucki@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).