From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B65E41CD27 for ; Tue, 6 Feb 2024 23:17:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707261455; cv=none; b=W3srRd50CnHzf4Pfh7i4csV1/SwCJhJgVHidKX1Cr2DR1EOStZKGmHGEUrwnvq5QpJQ2ZZrDBp2EZbSFkeoi5pIeS3LZxDwNvq7UdIe1afZ30b94jlGJlqw8+5e7QPN6ycm5oYxAXI57yAJX9YmjXhU7cMsnS5cOTglrGN7nnLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707261455; c=relaxed/simple; bh=xDeP1WzOK7z0TrBaP7cyYGKrsqjlegG7W3Yixb26mAM=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GFW3/mDLC/xgVAV4AtzmZlaT4qbDKwH4qfohWZpExs3FZrqaKKQb9RCXBrJFdnmMNX7gwhNwNLkxWfwSw6wkmRtv3rIiJaLns031PEgoQIJmNF8Qf13nFzlgsC2VBbmN6DaHMdHngTdGc+mG97gyI6rQyyNangOJTfsQt9ABL1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=N8p+DySB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="N8p+DySB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3F3EC433C7; Tue, 6 Feb 2024 23:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707261455; bh=xDeP1WzOK7z0TrBaP7cyYGKrsqjlegG7W3Yixb26mAM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=N8p+DySBWJ75qkCh7OjMVqv9bMVjApCJNhKXHlo2S+sDkIVQItorHFPY0strszai/ 3YlgUQbtcJz4asTMTowCqnHCrTkIQ3BpdnpJnZg6EYAFasbGKgkKjtVpHmTIowJ5xs A/bwZI9Tb6+w1e1k2ut0Cr++uml61X1D5/yNOg5GPktwZYumJjlVqptxU3CLLc8v22 0mQqg8hfe66G861JpvCwBE2Q1oIEwjmkrDyO/8zmiZdB8UQxODrvPxVenhNfEE/Nil V6p0e/bfQhM6eCUXCeQBayzNuS1aXwFb57FwPunnJuAA4f+wmwzw+YNc2oyK+yg05S +Py/FxQLeMvKA== Date: Tue, 6 Feb 2024 15:17:33 -0800 From: Jakub Kicinski To: "Keller, Jacob E" Cc: "Brady, Alan" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "willemdebruijn.kernel@gmail.com" , "Kitszel, Przemyslaw" , "Bagnucki, Igor" , "Lobakin, Aleksander" Subject: Re: [PATCH v4 00/10 iwl-next] idpf: refactor virtchnl messages Message-ID: <20240206151733.076ddfcd@kernel.org> In-Reply-To: References: <20240206033804.1198416-1-alan.brady@intel.com> <20240206105737.50149937@kernel.org> <20240206120303.0fd22238@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 6 Feb 2024 22:50:25 +0000 Keller, Jacob E wrote: > > Hm, okay, that does sound like making it worse. > > I'll disable the minmax coccicheck for now, it seems noisy. > > Maybe you could make the coccicheck only complain if the value is > non-zero or not const? Maybe that's a bit too complicated... Hm Non-zero could work. It may be worthwhile to look at the warnings cocci currently generates and figure out what's common among the cases where warning doesn't make sense.