* [PATCH net] selftests: bonding: fix macvlan2's namespace name
@ 2024-02-04 8:38 Hangbin Liu
2024-02-06 15:35 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Hangbin Liu @ 2024-02-04 8:38 UTC (permalink / raw)
To: netdev
Cc: Jay Vosburgh, David S . Miller, Jakub Kicinski, Paolo Abeni,
Eric Dumazet, Liang Li, Przemek Kitszel, Hangbin Liu
The m2's ns name should be m2-xxxxxx, not m1.
Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
index dc99e4ac262e..969bf9af1b94 100755
--- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
+++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
@@ -7,7 +7,7 @@ lib_dir=$(dirname "$0")
source ${lib_dir}/bond_topo_2d1c.sh
m1_ns="m1-$(mktemp -u XXXXXX)"
-m2_ns="m1-$(mktemp -u XXXXXX)"
+m2_ns="m2-$(mktemp -u XXXXXX)"
m1_ip4="192.0.2.11"
m1_ip6="2001:db8::11"
m2_ip4="192.0.2.12"
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: bonding: fix macvlan2's namespace name
2024-02-04 8:38 [PATCH net] selftests: bonding: fix macvlan2's namespace name Hangbin Liu
@ 2024-02-06 15:35 ` Simon Horman
2024-02-07 1:21 ` Jakub Kicinski
2024-02-07 1:45 ` Hangbin Liu
0 siblings, 2 replies; 4+ messages in thread
From: Simon Horman @ 2024-02-06 15:35 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, Jay Vosburgh, David S . Miller, Jakub Kicinski,
Paolo Abeni, Eric Dumazet, Liang Li, Przemek Kitszel
On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote:
> The m2's ns name should be m2-xxxxxx, not m1.
>
> Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Hi Hangbin Liu,
I agree this is a nice change.
But it is not clear to me that this is fixing a bug.
> ---
> tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> index dc99e4ac262e..969bf9af1b94 100755
> --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0")
> source ${lib_dir}/bond_topo_2d1c.sh
>
> m1_ns="m1-$(mktemp -u XXXXXX)"
> -m2_ns="m1-$(mktemp -u XXXXXX)"
> +m2_ns="m2-$(mktemp -u XXXXXX)"
> m1_ip4="192.0.2.11"
> m1_ip6="2001:db8::11"
> m2_ip4="192.0.2.12"
> --
> 2.43.0
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: bonding: fix macvlan2's namespace name
2024-02-06 15:35 ` Simon Horman
@ 2024-02-07 1:21 ` Jakub Kicinski
2024-02-07 1:45 ` Hangbin Liu
1 sibling, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-02-07 1:21 UTC (permalink / raw)
To: Simon Horman
Cc: Hangbin Liu, netdev, Jay Vosburgh, David S . Miller, Paolo Abeni,
Eric Dumazet, Liang Li, Przemek Kitszel
On Tue, 6 Feb 2024 15:35:15 +0000 Simon Horman wrote:
> On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote:
> > The m2's ns name should be m2-xxxxxx, not m1.
> >
> > Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>
> Hi Hangbin Liu,
>
> I agree this is a nice change.
> But it is not clear to me that this is fixing a bug.
Agreed, very unlikely mktemp would give us a collision.
Please resend for net-next with no fixes tag.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] selftests: bonding: fix macvlan2's namespace name
2024-02-06 15:35 ` Simon Horman
2024-02-07 1:21 ` Jakub Kicinski
@ 2024-02-07 1:45 ` Hangbin Liu
1 sibling, 0 replies; 4+ messages in thread
From: Hangbin Liu @ 2024-02-07 1:45 UTC (permalink / raw)
To: Simon Horman
Cc: netdev, Jay Vosburgh, David S . Miller, Jakub Kicinski,
Paolo Abeni, Eric Dumazet, Liang Li, Przemek Kitszel
On Tue, Feb 06, 2024 at 03:35:15PM +0000, Simon Horman wrote:
> On Sun, Feb 04, 2024 at 04:38:28PM +0800, Hangbin Liu wrote:
> > The m2's ns name should be m2-xxxxxx, not m1.
> >
> > Fixes: 246af950b940 ("selftests: bonding: add macvlan over bond testing")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>
> Hi Hangbin Liu,
>
> I agree this is a nice change.
> But it is not clear to me that this is fixing a bug.
Ah, you are right. I also just realise that the previous code also
works as we use mktemp, so the m1 and m2's name are unique, although
the m2's name using m1 as prefix.
Please feel free to drop this patch. I can do the name modification in future
when updating the bond_macvlan test.
Thanks
Hangbin
>
> > ---
> > tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> > index dc99e4ac262e..969bf9af1b94 100755
> > --- a/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> > +++ b/tools/testing/selftests/drivers/net/bonding/bond_macvlan.sh
> > @@ -7,7 +7,7 @@ lib_dir=$(dirname "$0")
> > source ${lib_dir}/bond_topo_2d1c.sh
> >
> > m1_ns="m1-$(mktemp -u XXXXXX)"
> > -m2_ns="m1-$(mktemp -u XXXXXX)"
> > +m2_ns="m2-$(mktemp -u XXXXXX)"
> > m1_ip4="192.0.2.11"
> > m1_ip6="2001:db8::11"
> > m2_ip4="192.0.2.12"
> > --
> > 2.43.0
> >
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-02-07 1:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-04 8:38 [PATCH net] selftests: bonding: fix macvlan2's namespace name Hangbin Liu
2024-02-06 15:35 ` Simon Horman
2024-02-07 1:21 ` Jakub Kicinski
2024-02-07 1:45 ` Hangbin Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).