From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"netdev-driver-reviewers@vger.kernel.org"
<netdev-driver-reviewers@vger.kernel.org>
Subject: Re: [TEST] Wiki / instructions
Date: Tue, 6 Feb 2024 17:37:05 -0800 [thread overview]
Message-ID: <20240206173705.544f4cb2@kernel.org> (raw)
In-Reply-To: <90c6d9b6-0bc4-468a-95fe-ebc2a23fffc1@kernel.org>
On Mon, 5 Feb 2024 18:21:56 +0100 Matthieu Baerts wrote:
> Thank you for this wiki page, and all the work with the CI infrastructure!
>
> For the debug options, I see that you are using:
>
> kernel/configs/x86_debug.config
>
> It looks like this is specific for the 'tip' tree:
>
> Debugging options for tip tree testing
>
> I don't know if it is still maintained, e.g. it includes DEBUG_SLAB
> option. But also, it enables options that are maybe not needed: GCOV?
> X86_DEBUG_FPU?
> Maybe it is better not to use this .config file, no?
I haven't looked to closely. I noticed that the basic debug config
doesn't enable LOCKDEP ?! so I put the x86 one on top.
I added a local patch to cut out all the obviously pointless stuff from
x86_debug.config, we should probably start our own config for networking
at some stage.
> For our CI validating MPTCP tests in a "debug" mode, we use
> "debug.config" without "x86_debug.config". On top of that, we also
> disable "SLUB_DEBUG_ON", because the impact on the perf is too
> important, especially with slow environments. We think it is not worth
> it for our case. You don't have the same hardware, but if you have perf
> issues, don't hesitate to do the same ;)
The mptcp tests take <60min to run with debug enabled, and just
a single thread / VM. I think that's fine for now. But thanks for
the heads up that SLUB_DEBUG_ON is problematic, for it may matter for
forwarding or net tests.
next prev parent reply other threads:[~2024-02-07 1:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 17:31 [TEST] Wiki / instructions Jakub Kicinski
2024-02-05 17:21 ` Matthieu Baerts
2024-02-07 1:37 ` Jakub Kicinski [this message]
2024-02-07 8:50 ` Matthieu Baerts
2024-02-07 15:21 ` Jakub Kicinski
2024-02-07 15:59 ` Matthieu Baerts
2024-02-08 2:11 ` Jakub Kicinski
2024-02-09 10:25 ` Simon Horman
2024-02-09 15:30 ` Jakub Kicinski
2024-02-16 17:01 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206173705.544f4cb2@kernel.org \
--to=kuba@kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev-driver-reviewers@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).