[PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}

[PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}

[Masahiro Yamada]

The 'bool' is already specified for these options.

The second 'bool' under the help message is redundant.

While I am here, I moved 'default y' above, as it is common to place
the help text last.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 net/tipc/Kconfig | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
index be1c4003d67d..bb0d71eb02a6 100644
--- a/net/tipc/Kconfig
+++ b/net/tipc/Kconfig
@@ -32,16 +32,17 @@ config TIPC_MEDIA_UDP
 	bool "IP/UDP media type support"
 	depends on TIPC
 	select NET_UDP_TUNNEL
+	default y
 	help
 	  Saying Y here will enable support for running TIPC over IP/UDP
-	bool
-	default y
+
 config TIPC_CRYPTO
 	bool "TIPC encryption support"
 	depends on TIPC
 	select CRYPTO
 	select CRYPTO_AES
 	select CRYPTO_GCM
+	default y
 	help
 	  Saying Y here will enable support for TIPC encryption.
 	  All TIPC messages will be encrypted/decrypted by using the currently most
@@ -49,8 +50,6 @@ config TIPC_CRYPTO
 	  entering the TIPC stack.
 	  Key setting from user-space is performed via netlink by a user program
 	  (e.g. the iproute2 'tipc' tool).
-	bool
-	default y
 
 config TIPC_DIAG
 	tristate "TIPC: socket monitoring interface"
-- 
2.40.1

Re: [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}

[Randy Dunlap]

On 2/4/24 05:12, Masahiro Yamada wrote:
> The 'bool' is already specified for these options.
> 
> The second 'bool' under the help message is redundant.
> 
> While I am here, I moved 'default y' above, as it is common to place
> the help text last.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> 
>  net/tipc/Kconfig | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig
> index be1c4003d67d..bb0d71eb02a6 100644
> --- a/net/tipc/Kconfig
> +++ b/net/tipc/Kconfig
> @@ -32,16 +32,17 @@ config TIPC_MEDIA_UDP
>  	bool "IP/UDP media type support"
>  	depends on TIPC
>  	select NET_UDP_TUNNEL
> +	default y
>  	help
>  	  Saying Y here will enable support for running TIPC over IP/UDP
> -	bool
> -	default y
> +
>  config TIPC_CRYPTO
>  	bool "TIPC encryption support"
>  	depends on TIPC
>  	select CRYPTO
>  	select CRYPTO_AES
>  	select CRYPTO_GCM
> +	default y
>  	help
>  	  Saying Y here will enable support for TIPC encryption.
>  	  All TIPC messages will be encrypted/decrypted by using the currently most
> @@ -49,8 +50,6 @@ config TIPC_CRYPTO
>  	  entering the TIPC stack.
>  	  Key setting from user-space is performed via netlink by a user program
>  	  (e.g. the iproute2 'tipc' tool).
> -	bool
> -	default y
>  
>  config TIPC_DIAG
>  	tristate "TIPC: socket monitoring interface"

-- 
#Randy

Re: [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}

[Simon Horman]

On Sun, Feb 04, 2024 at 10:12:26PM +0900, Masahiro Yamada wrote:
> The 'bool' is already specified for these options.
> 
> The second 'bool' under the help message is redundant.
> 
> While I am here, I moved 'default y' above, as it is common to place
> the help text last.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Thanks Yamada-san,

this looks good to me.

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH] net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sun,  4 Feb 2024 22:12:26 +0900 you wrote:
> The 'bool' is already specified for these options.
> 
> The second 'bool' under the help message is redundant.
> 
> While I am here, I moved 'default y' above, as it is common to place
> the help text last.
> 
> [...]

Here is the summary with links:
  - net: tipc: remove redundant 'bool' from CONFIG_TIPC_{MEDIA_UDP,CRYPTO}
    https://git.kernel.org/netdev/net-next/c/59d6bccebe5c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html