From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net] selftests: cmsg_ipv6: repeat the exact packet
Date: Tue, 6 Feb 2024 18:08:38 +0000 [thread overview]
Message-ID: <20240206180838.GH1104779@kernel.org> (raw)
In-Reply-To: <20240204165618.1489880-1-kuba@kernel.org>
On Sun, Feb 04, 2024 at 08:56:18AM -0800, Jakub Kicinski wrote:
> cmsg_ipv6 test requests tcpdump to capture 4 packets,
> and sends until tcpdump quits. Only the first packet
> is "real", however, and the rest are basic UDP packets.
> So if tcpdump doesn't start in time it will miss
> the real packet and only capture the UDP ones.
>
> This makes the test fail on slow machine (no KVM or with
> debug enabled) 100% of the time, while it passes in fast
> environments.
>
> Repeat the "real" / expected packet.
>
> Fixes: 9657ad09e1fa ("selftests: net: test IPV6_TCLASS")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
I'm not sure if it is important, but doesn't this also:
Fixes: 05ae83d5a4a2 ("selftests: net: test IPV6_HOPLIMIT")
In any case, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-06 18:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 16:56 [PATCH net] selftests: cmsg_ipv6: repeat the exact packet Jakub Kicinski
2024-02-06 18:08 ` Simon Horman [this message]
2024-02-07 13:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206180838.GH1104779@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).