From: Jakub Kicinski <kuba@kernel.org>
To: Geoff Levand <geoff@infradead.org>
Cc: sambat goson <sombat3960@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v2 net] ps3/gelic: Fix SKB allocation
Date: Tue, 6 Feb 2024 18:52:27 -0800 [thread overview]
Message-ID: <20240206185227.5c167ea5@kernel.org> (raw)
In-Reply-To: <2acf3fe5-7206-46d6-adac-0bf40d175d5d@infradead.org>
On Mon, 5 Feb 2024 10:48:07 +0900 Geoff Levand wrote:
> Commit 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures")
> of 6.8-rc1 did not set up the network SKB's correctly, resulting in
> a kernel panic.
>
> This fix changes the way the napi buffer and corresponding SKB are
> allocated and managed.
>
> Reported-by: sambat goson <sombat3960@gmail.com>
> Fixes: 3ce4f9c3fbb3 ("net/ps3_gelic_net: Add gelic_descr structures")
> Signed-off-by: Geoff Levand <geoff@infradead.org>
Please make the commit message describe the problem in more detail.
It's also indented for no reason.
prev parent reply other threads:[~2024-02-07 2:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 1:48 [PATCH v2 net] ps3/gelic: Fix SKB allocation Geoff Levand
2024-02-07 2:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240206185227.5c167ea5@kernel.org \
--to=kuba@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=geoff@infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sombat3960@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).