From: Jakub Kicinski <kuba@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
David Miller <davem@davemloft.net>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Igor Russkikh <irusskikh@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next] net: atlantic: convert EEE handling to use linkmode bitmaps
Date: Wed, 7 Feb 2024 07:53:14 -0800 [thread overview]
Message-ID: <20240207075314.5458bd68@kernel.org> (raw)
In-Reply-To: <2046e53a-6de4-41e0-b816-3e7926ad489b@gmail.com>
On Wed, 7 Feb 2024 07:52:49 +0100 Heiner Kallweit wrote:
> > This is again a correct translation. But the underlying implementation
> > seems wrong. aq_ethtool_set_eee() does not appear to allow the
> > advertisement to be changed, so advertised does equal
> > supported. However aq_ethtool_set_eee() does not validate that the
> > user is not changing what is advertised and returning an error. Lets
> > leave it broken, and see if Aquantia/Marvell care.
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> This patch was by mistake set to "Changes requested".
It's because of the comment about zeroing, not the latter one.
Sorry, it's impossible for me to guess whether he meant the tag
for v2 or he's fine with the patch as is. Andrew has the powers
to change pw state, I'm leaving this to him.
next prev parent reply other threads:[~2024-02-07 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 21:25 [PATCH net-next] net: atlantic: convert EEE handling to use linkmode bitmaps Heiner Kallweit
2024-02-03 21:50 ` Andrew Lunn
2024-02-07 6:52 ` Heiner Kallweit
2024-02-07 15:53 ` Jakub Kicinski [this message]
2024-02-07 16:14 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207075314.5458bd68@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=irusskikh@marvell.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).