From: Jakub Kicinski <kuba@kernel.org>
To: Allison Henderson <allison.henderson@oracle.com>
Cc: "rds-devel@oss.oracle.com" <rds-devel@oss.oracle.com>,
Santosh Shilimkar <santosh.shilimkar@oracle.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v2 1/1] net:rds: Fix possible deadlock in rds_message_put
Date: Wed, 7 Feb 2024 09:59:14 -0800 [thread overview]
Message-ID: <20240207095914.49ba5293@kernel.org> (raw)
In-Reply-To: <6c63549d6771bfb1ab410338b2dcea3e3fedb415.camel@oracle.com>
On Wed, 7 Feb 2024 17:23:53 +0000 Allison Henderson wrote:
> > This is not a correct Fixes tag. Please look at git history
>
> Sorry, the fixes tag identifies the offending commit? I think it's an
> existing bug since the code was introduced. Which would be:
>
> Fixes: bdbe6fbc6a2f (RDS: recv.c)
>
> If that's not a useful tag, I can remove it too. The syzbot bisect
> points to a virtio commit 1628c6877f37, but that doesn't look correct
> to me. Let me know what you would prefer. Thank you!
The initial commit for the code base is very useful to backporters!
It tells them "you have to backport this all the way down".
Lack of a Fixes tag says "I don't know where the bug was added".
Fixes tags are more about telling backporters how far to backport
than about blame.
next prev parent reply other threads:[~2024-02-07 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 17:54 [PATCH v2 1/1] net:rds: Fix possible deadlock in rds_message_put allison.henderson
2024-02-07 2:48 ` Jakub Kicinski
2024-02-07 17:23 ` Allison Henderson
2024-02-07 17:59 ` Jakub Kicinski [this message]
2024-02-07 20:17 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207095914.49ba5293@kernel.org \
--to=kuba@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).