* [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe()
@ 2024-02-05 12:54 Markus Elfring
2024-02-05 20:47 ` Gerhard Engleder
2024-02-07 19:41 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Markus Elfring @ 2024-02-05 12:54 UTC (permalink / raw)
To: netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Gerhard Engleder, Heiner Kallweit, Jakub Kicinski,
Maciej Fijalkowski, Paolo Abeni, Yunsheng Lin
Cc: LKML
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Mon, 5 Feb 2024 13:43:14 +0100
A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
("drivers: provide devm_platform_get_and_ioremap_resource()").
Thus reuse existing functionality instead of keeping duplicate source code.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/net/ethernet/engleder/tsnep_main.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/engleder/tsnep_main.c b/drivers/net/ethernet/engleder/tsnep_main.c
index eb64118f5b18..498c4d47e0fa 100644
--- a/drivers/net/ethernet/engleder/tsnep_main.c
+++ b/drivers/net/ethernet/engleder/tsnep_main.c
@@ -2564,8 +2564,7 @@ static int tsnep_probe(struct platform_device *pdev)
mutex_init(&adapter->rxnfc_lock);
INIT_LIST_HEAD(&adapter->rxnfc_rules);
- io = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- adapter->addr = devm_ioremap_resource(&pdev->dev, io);
+ adapter->addr = devm_platform_get_and_ioremap_resource(pdev, 0, &io);
if (IS_ERR(adapter->addr))
return PTR_ERR(adapter->addr);
netdev->mem_start = io->start;
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe()
2024-02-05 12:54 [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe() Markus Elfring
@ 2024-02-05 20:47 ` Gerhard Engleder
2024-02-07 19:41 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Gerhard Engleder @ 2024-02-05 20:47 UTC (permalink / raw)
To: Markus Elfring, netdev, kernel-janitors, David S. Miller,
Eric Dumazet, Heiner Kallweit, Jakub Kicinski, Maciej Fijalkowski,
Paolo Abeni, Yunsheng Lin
Cc: LKML
On 05.02.24 13:54, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 5 Feb 2024 13:43:14 +0100
>
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Tested-by: Gerhard Engleder <gerhard@engleder-embedded.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe()
2024-02-05 12:54 [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe() Markus Elfring
2024-02-05 20:47 ` Gerhard Engleder
@ 2024-02-07 19:41 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-02-07 19:41 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, kernel-janitors, David S. Miller, Eric Dumazet,
Gerhard Engleder, Heiner Kallweit, Maciej Fijalkowski,
Paolo Abeni, Yunsheng Lin, LKML
On Mon, 5 Feb 2024 13:54:24 +0100 Markus Elfring wrote:
> A wrapper function is available since the commit 890cc39a879906b63912482dfc41944579df2dc6
> ("drivers: provide devm_platform_get_and_ioremap_resource()").
> Thus reuse existing functionality instead of keeping duplicate source code.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
applied, thanks!
--
pw-bot: accept
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-07 19:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-05 12:54 [PATCH] tsnep: Use devm_platform_get_and_ioremap_resource() in tsnep_probe() Markus Elfring
2024-02-05 20:47 ` Gerhard Engleder
2024-02-07 19:41 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).