From: Jakub Kicinski <kuba@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Matthieu Baerts <matttbe@kernel.org>,
Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev@googlegroups.com, Netdev <netdev@vger.kernel.org>,
linux-hardening@vger.kernel.org,
Kees Cook <keescook@chromium.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: KFENCE: included in x86 defconfig?
Date: Wed, 7 Feb 2024 15:33:27 -0800 [thread overview]
Message-ID: <20240207153327.22b5c848@kernel.org> (raw)
In-Reply-To: <20240207190444.GFZcPUTAnZb_aSlSjV@fat_crate.local>
On Wed, 7 Feb 2024 20:04:44 +0100 Borislav Petkov wrote:
> On Wed, Feb 07, 2024 at 07:35:53PM +0100, Matthieu Baerts wrote:
> > Sorry, I'm sure I understand your suggestion: do you mean not including
> > KFENCE in hardening.config either, but in another one?
> >
> > For the networking tests, we are already merging .config files, e.g. the
> > debug.config one. We are not pushing to have KFENCE in x86 defconfig, it
> > can be elsewhere, and we don't mind merging other .config files if they
> > are maintained.
>
> Well, depends on where should KFENCE be enabled? Do you want people to
> run their tests with it too, or only the networking tests? If so, then
> hardening.config probably makes sense.
>
> Judging by what Documentation/dev-tools/kfence.rst says:
>
> "KFENCE is designed to be enabled in production kernels, and has near zero
> performance overhead."
>
> this reads like it should be enabled *everywhere* - not only in some
> hardening config.
Right, a lot of distros enable it and so do hyperscalers (Fedora, Meta
and Google at least, AFAIK). Linus is pretty clear on the policy that
"feature" type Kconfig options should default to disabled. But for
something like KFENCE we were wondering what the cut-over point is
for making it enabled by default.
next prev parent reply other threads:[~2024-02-07 23:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 16:16 KFENCE: included in x86 defconfig? Matthieu Baerts
2024-02-07 18:05 ` Marco Elver
2024-02-07 18:16 ` Borislav Petkov
2024-02-07 18:35 ` Matthieu Baerts
2024-02-07 19:04 ` Borislav Petkov
2024-02-07 22:12 ` Matthieu Baerts
2024-02-07 22:21 ` Marco Elver
2024-02-07 23:33 ` Jakub Kicinski [this message]
2024-02-08 7:47 ` Marco Elver
2024-02-08 10:55 ` Borislav Petkov
2024-02-08 11:11 ` Linus Torvalds
2024-02-08 11:12 ` Marco Elver
2024-02-08 12:01 ` Borislav Petkov
2024-02-07 18:28 ` Matthieu Baerts
2024-02-10 6:25 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207153327.22b5c848@kernel.org \
--to=kuba@kernel.org \
--cc=bp@alien8.de \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).