[PATCH net-next] r8169: remove setting LED default trigger, this is done by LED core now

[PATCH net-next] r8169: remove setting LED default trigger, this is done by LED core now

[Heiner Kallweit]

After 1c75c424bd43 ("leds: class: If no default trigger is given, make
hw_control trigger the default trigger") this line isn't needed any
longer.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/net/ethernet/realtek/r8169_leds.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169_leds.c b/drivers/net/ethernet/realtek/r8169_leds.c
index 007d077ed..f082bd7d6 100644
--- a/drivers/net/ethernet/realtek/r8169_leds.c
+++ b/drivers/net/ethernet/realtek/r8169_leds.c
@@ -129,7 +129,6 @@ static void rtl8168_setup_ldev(struct r8169_led_classdev *ldev,
 
 	r8169_get_led_name(tp, index, led_name, LED_MAX_NAME_SIZE);
 	led_cdev->name = led_name;
-	led_cdev->default_trigger = "netdev";
 	led_cdev->hw_control_trigger = "netdev";
 	led_cdev->flags |= LED_RETAIN_AT_SHUTDOWN;
 	led_cdev->hw_control_is_supported = rtl8168_led_hw_control_is_supported;
-- 
2.43.0

Re: [PATCH net-next] r8169: remove setting LED default trigger, this is done by LED core now

[Simon Horman]

On Mon, Feb 05, 2024 at 10:54:08PM +0100, Heiner Kallweit wrote:
> After 1c75c424bd43 ("leds: class: If no default trigger is given, make
> hw_control trigger the default trigger") this line isn't needed any
> longer.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

This patch looks fine to me,
but the cited commit is not present in net-next.

Re: [PATCH net-next] r8169: remove setting LED default trigger, this is done by LED core now

[Heiner Kallweit]

On 07.02.2024 21:07, Simon Horman wrote:
> On Mon, Feb 05, 2024 at 10:54:08PM +0100, Heiner Kallweit wrote:
>> After 1c75c424bd43 ("leds: class: If no default trigger is given, make
>> hw_control trigger the default trigger") this line isn't needed any
>> longer.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> 
> This patch looks fine to me,
> but the cited commit is not present in net-next.

It's present in linux-next. Not sure when it will show up in net-next.

Re: [PATCH net-next] r8169: remove setting LED default trigger, this is done by LED core now

[Andrew Lunn]

On Wed, Feb 07, 2024 at 09:43:38PM +0100, Heiner Kallweit wrote:
> On 07.02.2024 21:07, Simon Horman wrote:
> > On Mon, Feb 05, 2024 at 10:54:08PM +0100, Heiner Kallweit wrote:
> >> After 1c75c424bd43 ("leds: class: If no default trigger is given, make
> >> hw_control trigger the default trigger") this line isn't needed any
> >> longer.
> >>
> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> > 
> > This patch looks fine to me,
> > but the cited commit is not present in net-next.
> 
> It's present in linux-next. Not sure when it will show up in net-next.

1c75c424bd43 was merged via for-leds-next, which is probably why Simon
does not see it.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next] r8169: remove setting LED default trigger, this is done by LED core now

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 5 Feb 2024 22:54:08 +0100 you wrote:
> After 1c75c424bd43 ("leds: class: If no default trigger is given, make
> hw_control trigger the default trigger") this line isn't needed any
> longer.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
>  drivers/net/ethernet/realtek/r8169_leds.c | 1 -
>  1 file changed, 1 deletion(-)

Here is the summary with links:
  - [net-next] r8169: remove setting LED default trigger, this is done by LED core now
    https://git.kernel.org/netdev/net-next/c/c885b95c58dd

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html