netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maks Mishin <maks.mishinfz@gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Maks Mishin <maks.mishinFZ@gmail.com>, netdev@vger.kernel.org
Subject: [PATCH] m_pedit: Fix descriptor leak in get_pedit_kind()
Date: Thu,  8 Feb 2024 00:42:24 +0300	[thread overview]
Message-ID: <20240207214224.19088-1-maks.mishinFZ@gmail.com> (raw)

Found by RASU JSC

Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
 tc/m_pedit.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 32f03415..b5965250 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@ -95,6 +95,9 @@ static struct m_pedit_util *get_pedit_kind(const char *str)
 
 	snprintf(buf, sizeof(buf), "p_pedit_%s", str);
 	p = dlsym(dlh, buf);
+	if (dlh != NULL)
+		dlclose(dlh);
+
 	if (p == NULL)
 		goto noexist;
 
-- 
2.30.2


             reply	other threads:[~2024-02-07 21:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 21:42 Maks Mishin [this message]
2024-02-08 17:06 ` [PATCH] m_pedit: Fix descriptor leak in get_pedit_kind() Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207214224.19088-1-maks.mishinFZ@gmail.com \
    --to=maks.mishinfz@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).