From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: mptcp@lists.linux.dev, Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Kishen Maloor <kishen.maloor@intel.com>,
Florian Westphal <fw@strlen.de>,
Peter Krystad <peter.krystad@linux.intel.com>,
Dmytro Shytyi <dmytro@shytyi.net>,
Benjamin Hesmans <benjamin.hesmans@tessares.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Paasch <cpaasch@apple.com>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
stable@vger.kernel.org,
syzbot+c53d4d3ddb327e80bc51@syzkaller.appspotmail.com,
Geliang Tang <geliang@kernel.org>
Subject: [PATCH net 0/7] mptcp: locking cleanup & misc. fixes
Date: Thu, 08 Feb 2024 19:03:48 +0100 [thread overview]
Message-ID: <20240208-upstream-net-20240202-locking-cleanup-misc-v1-0-f75cc5b97e5a@kernel.org> (raw)
Patches 1-4 are fixes for issues found by Paolo while working on adding
TCP_NOTSENT_LOWAT support. The latter will need to track more states
under the msk data lock. Since the locking msk locking schema is already
quite complex, do a long awaited clean-up step by moving several
confusing lockless initialization under the relevant locks. Note that it
is unlikely a real race could happen even prior to such patches as the
MPTCP-level state machine implicitly ensures proper serialization of the
write accesses, even lacking explicit lock. But still, simplification is
welcome and this will help for the maintenance. This can be backported
up to v5.6.
Patch 5 is a fix for the userspace PM, not to add new local address
entries if the address is already in the list. This behaviour can be
seen since v5.19.
Patch 6 fixes an issue when Fastopen is used. The issue can happen since
v6.2. A previous fix has already been applied, but not taking care of
all cases according to syzbot.
Patch 7 updates Geliang's email address in the MAINTAINERS file.
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
Geliang Tang (2):
mptcp: check addrs list in userspace_pm_get_local_id
MAINTAINERS: update Geliang's email address
Paolo Abeni (5):
mptcp: drop the push_pending field
mptcp: fix rcv space initialization
mptcp: fix more tx path fields initialization
mptcp: corner case locking for rx path fields initialization
mptcp: really cope with fastopen race
.mailmap | 9 +++---
MAINTAINERS | 2 +-
net/mptcp/fastopen.c | 6 ++--
net/mptcp/options.c | 9 +++---
net/mptcp/pm_userspace.c | 13 ++++++++-
net/mptcp/protocol.c | 31 +++++++++++----------
net/mptcp/protocol.h | 16 ++++++-----
net/mptcp/subflow.c | 71 ++++++++++++++++++++++++++++++------------------
8 files changed, 95 insertions(+), 62 deletions(-)
---
base-commit: 335bac1daae3fd9070d0f9f34d7d7ba708729256
change-id: 20240202-upstream-net-20240202-locking-cleanup-misc-5f2ee79d8356
Best regards,
--
Matthieu Baerts (NGI0) <matttbe@kernel.org>
next reply other threads:[~2024-02-08 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 18:03 Matthieu Baerts (NGI0) [this message]
2024-02-08 18:03 ` [PATCH net 1/7] mptcp: drop the push_pending field Matthieu Baerts (NGI0)
2024-02-08 18:03 ` [PATCH net 2/7] mptcp: fix rcv space initialization Matthieu Baerts (NGI0)
2024-02-08 18:03 ` [PATCH net 3/7] mptcp: fix more tx path fields initialization Matthieu Baerts (NGI0)
2024-02-08 18:03 ` [PATCH net 4/7] mptcp: corner case locking for rx " Matthieu Baerts (NGI0)
2024-02-08 18:03 ` [PATCH net 5/7] mptcp: check addrs list in userspace_pm_get_local_id Matthieu Baerts (NGI0)
2024-02-08 18:03 ` [PATCH net 6/7] mptcp: really cope with fastopen race Matthieu Baerts (NGI0)
2024-02-08 18:03 ` [PATCH net 7/7] MAINTAINERS: update Geliang's email address Matthieu Baerts (NGI0)
2024-02-12 10:10 ` [PATCH net 0/7] mptcp: locking cleanup & misc. fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208-upstream-net-20240202-locking-cleanup-misc-v1-0-f75cc5b97e5a@kernel.org \
--to=matttbe@kernel.org \
--cc=benjamin.hesmans@tessares.net \
--cc=cpaasch@apple.com \
--cc=davem@davemloft.net \
--cc=dmytro@shytyi.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=geliang@kernel.org \
--cc=kishen.maloor@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter.krystad@linux.intel.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+c53d4d3ddb327e80bc51@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).