From: Stephen Hemminger <stephen@networkplumber.org>
To: Maks Mishin <maks.mishinfz@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipaddrlabel: Fix descriptor leak in flush_addrlabel()
Date: Thu, 8 Feb 2024 08:56:17 -0800 [thread overview]
Message-ID: <20240208085617.1fc58a59@hermes.local> (raw)
In-Reply-To: <20240207202542.9872-1-maks.mishinFZ@gmail.com>
On Wed, 7 Feb 2024 23:25:42 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:
> Added closure of descriptor `rth2.fd` created by rtnl_open() when
> returning from function.
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
> ip/ipaddrlabel.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ip/ipaddrlabel.c b/ip/ipaddrlabel.c
> index b045827a..3857fcf5 100644
> --- a/ip/ipaddrlabel.c
> +++ b/ip/ipaddrlabel.c
> @@ -201,8 +201,10 @@ static int flush_addrlabel(struct nlmsghdr *n, void *arg)
> n->nlmsg_type = RTM_DELADDRLABEL;
> n->nlmsg_flags = NLM_F_REQUEST;
>
> - if (rtnl_open(&rth2, 0) < 0)
> + if (rtnl_open(&rth2, 0) < 0) {
> + rtnl_close(&rth2);
> return -1;
> + }
>
> if (rtnl_talk(&rth2, n, NULL) < 0)
> return -2;
This doesn't make sense, the error path in rtnl_open cleans up
itself. Do you have a reproducer or is this just some static analyzer?
prev parent reply other threads:[~2024-02-08 16:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 20:25 [PATCH] ipaddrlabel: Fix descriptor leak in flush_addrlabel() Maks Mishin
2024-02-08 13:32 ` Donald Hunter
2024-02-08 16:56 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208085617.1fc58a59@hermes.local \
--to=stephen@networkplumber.org \
--cc=maks.mishinfz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).