From: Stephen Hemminger <stephen@networkplumber.org>
To: Maks Mishin <maks.mishinfz@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] iplink: Fix descriptor leak in get_link_kind()
Date: Thu, 8 Feb 2024 09:05:21 -0800 [thread overview]
Message-ID: <20240208090521.14c5e230@hermes.local> (raw)
In-Reply-To: <20240207210450.14652-1-maks.mishinFZ@gmail.com>
On Thu, 8 Feb 2024 00:04:50 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:
> Found by RASU JSC
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
> ip/iplink.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/ip/iplink.c b/ip/iplink.c
> index 95314af5..7e31b95c 100644
> --- a/ip/iplink.c
> +++ b/ip/iplink.c
> @@ -168,6 +168,9 @@ struct link_util *get_link_kind(const char *id)
>
> snprintf(buf, sizeof(buf), "%s_link_util", id);
> l = dlsym(dlh, buf);
> + if (dlh != NULL)
> + dlclose(dlh);
> +
> if (l == NULL)
> return NULL;
>
NAK this will break the caching of BODY.
prev parent reply other threads:[~2024-02-08 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 21:04 [PATCH] iplink: Fix descriptor leak in get_link_kind() Maks Mishin
2024-02-08 17:05 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208090521.14c5e230@hermes.local \
--to=stephen@networkplumber.org \
--cc=maks.mishinfz@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).