* [PATCH] m_action: Fix descriptor leak in get_action_kind()
@ 2024-02-07 21:16 Maks Mishin
2024-02-08 17:05 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Maks Mishin @ 2024-02-07 21:16 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Maks Mishin, netdev
Found by RASU JSC
Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
tc/m_action.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tc/m_action.c b/tc/m_action.c
index 16474c56..7d18f7fa 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -111,6 +111,9 @@ restart_s:
snprintf(buf, sizeof(buf), "%s_action_util", str);
a = dlsym(dlh, buf);
+ if (dlh != NULL)
+ dlclose(dlh);
+
if (a == NULL)
goto noexist;
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] m_action: Fix descriptor leak in get_action_kind()
2024-02-07 21:16 [PATCH] m_action: Fix descriptor leak in get_action_kind() Maks Mishin
@ 2024-02-08 17:05 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2024-02-08 17:05 UTC (permalink / raw)
To: Maks Mishin; +Cc: netdev
On Thu, 8 Feb 2024 00:16:32 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:
> Found by RASU JSC
>
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
> ---
> tc/m_action.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tc/m_action.c b/tc/m_action.c
> index 16474c56..7d18f7fa 100644
> --- a/tc/m_action.c
> +++ b/tc/m_action.c
> @@ -111,6 +111,9 @@ restart_s:
>
> snprintf(buf, sizeof(buf), "%s_action_util", str);
> a = dlsym(dlh, buf);
> + if (dlh != NULL)
> + dlclose(dlh);
> +
> if (a == NULL)
> goto noexist;
>
NAK again, this will break the caching
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-08 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-07 21:16 [PATCH] m_action: Fix descriptor leak in get_action_kind() Maks Mishin
2024-02-08 17:05 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).