netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] m_pedit: Fix descriptor leak in get_pedit_kind()
@ 2024-02-07 21:42 Maks Mishin
  2024-02-08 17:06 ` Stephen Hemminger
  0 siblings, 1 reply; 2+ messages in thread
From: Maks Mishin @ 2024-02-07 21:42 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: Maks Mishin, netdev

Found by RASU JSC

Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>
---
 tc/m_pedit.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index 32f03415..b5965250 100644
--- a/tc/m_pedit.c
+++ b/tc/m_pedit.c
@@ -95,6 +95,9 @@ static struct m_pedit_util *get_pedit_kind(const char *str)
 
 	snprintf(buf, sizeof(buf), "p_pedit_%s", str);
 	p = dlsym(dlh, buf);
+	if (dlh != NULL)
+		dlclose(dlh);
+
 	if (p == NULL)
 		goto noexist;
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] m_pedit: Fix descriptor leak in get_pedit_kind()
  2024-02-07 21:42 [PATCH] m_pedit: Fix descriptor leak in get_pedit_kind() Maks Mishin
@ 2024-02-08 17:06 ` Stephen Hemminger
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2024-02-08 17:06 UTC (permalink / raw)
  To: Maks Mishin; +Cc: netdev

On Thu,  8 Feb 2024 00:42:24 +0300
Maks Mishin <maks.mishinfz@gmail.com> wrote:

> Found by RASU JSC
> 
> Signed-off-by: Maks Mishin <maks.mishinFZ@gmail.com>

NAK again will break caching of pBODY.
You get the idea, not going to look at more of these RASU patches.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-08 17:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-07 21:42 [PATCH] m_pedit: Fix descriptor leak in get_pedit_kind() Maks Mishin
2024-02-08 17:06 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).