[PATCH net-next 1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb()

[PATCH net-next 1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb()

[Vladimir Oltean]

The convention is to not use "inline" functions in C files, and let the
compiler decide whether to inline or not.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/user.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/dsa/user.c b/net/dsa/user.c
index ba2e53b5e16a..5d666dfb317d 100644
--- a/net/dsa/user.c
+++ b/net/dsa/user.c
@@ -875,8 +875,8 @@ static int dsa_user_port_obj_del(struct net_device *dev, const void *ctx,
 	return err;
 }
 
-static inline netdev_tx_t dsa_user_netpoll_send_skb(struct net_device *dev,
-						    struct sk_buff *skb)
+static netdev_tx_t dsa_user_netpoll_send_skb(struct net_device *dev,
+					     struct sk_buff *skb)
 {
 #ifdef CONFIG_NET_POLL_CONTROLLER
 	struct dsa_user_priv *p = netdev_priv(dev);
-- 
2.34.1

[PATCH net-next 2/2] net: dsa: tag_sja1105: remove "inline" keyword

[Vladimir Oltean]

The convention is to not use the "inline" keyword for functions in C
files, but to let the compiler choose.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 net/dsa/tag_sja1105.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/dsa/tag_sja1105.c b/net/dsa/tag_sja1105.c
index 2717e9d7b612..1aba1d05c27a 100644
--- a/net/dsa/tag_sja1105.c
+++ b/net/dsa/tag_sja1105.c
@@ -75,7 +75,7 @@ sja1105_tagger_private(struct dsa_switch *ds)
 }
 
 /* Similar to is_link_local_ether_addr(hdr->h_dest) but also covers PTP */
-static inline bool sja1105_is_link_local(const struct sk_buff *skb)
+static bool sja1105_is_link_local(const struct sk_buff *skb)
 {
 	const struct ethhdr *hdr = eth_hdr(skb);
 	u64 dmac = ether_addr_to_u64(hdr->h_dest);
@@ -121,7 +121,7 @@ static void sja1105_meta_unpack(const struct sk_buff *skb,
 	packing(buf + 7, &meta->switch_id,   7, 0, 1, UNPACK, 0);
 }
 
-static inline bool sja1105_is_meta_frame(const struct sk_buff *skb)
+static bool sja1105_is_meta_frame(const struct sk_buff *skb)
 {
 	const struct ethhdr *hdr = eth_hdr(skb);
 	u64 smac = ether_addr_to_u64(hdr->h_source);
-- 
2.34.1

Re: [PATCH net-next 1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb()

[Simon Horman]

On Tue, Feb 06, 2024 at 01:29:26PM +0200, Vladimir Oltean wrote:
> The convention is to not use "inline" functions in C files, and let the
> compiler decide whether to inline or not.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 2/2] net: dsa: tag_sja1105: remove "inline" keyword

[Simon Horman]

On Tue, Feb 06, 2024 at 01:29:27PM +0200, Vladimir Oltean wrote:
> The convention is to not use the "inline" keyword for functions in C
> files, but to let the compiler choose.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next 1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb()

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue,  6 Feb 2024 13:29:26 +0200 you wrote:
> The convention is to not use "inline" functions in C files, and let the
> compiler decide whether to inline or not.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  net/dsa/user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Here is the summary with links:
  - [net-next,1/2] net: dsa: remove "inline" from dsa_user_netpoll_send_skb()
    https://git.kernel.org/netdev/net-next/c/83acbb9d0716
  - [net-next,2/2] net: dsa: tag_sja1105: remove "inline" keyword
    https://git.kernel.org/netdev/net-next/c/36f75f74dc07

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html