From: Simon Horman <horms@kernel.org>
To: Alan Brady <alan.brady@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Emil Tantilov <emil.s.tantilov@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets
Date: Fri, 9 Feb 2024 10:34:20 +0000 [thread overview]
Message-ID: <20240209103420.GD1516992@kernel.org> (raw)
In-Reply-To: <20240208004243.1762223-1-alan.brady@intel.com>
On Wed, Feb 07, 2024 at 04:42:43PM -0800, Alan Brady wrote:
> From: Emil Tantilov <emil.s.tantilov@intel.com>
>
> Fix softirq's not being handled during napi_schedule() call when
> receiving marker packets for queue disable by disabling local bottom
> half.
>
> The issue can be seen on ifdown:
> NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!
>
> Using ftrace to catch the failing scenario:
> ifconfig [003] d.... 22739.830624: softirq_raise: vec=3 [action=NET_RX]
> <idle>-0 [003] ..s.. 22739.831357: softirq_entry: vec=3 [action=NET_RX]
>
> No interrupt and CPU is idle.
>
> After the patch, with BH locks:
> ifconfig [003] d.... 22993.928336: softirq_raise: vec=3 [action=NET_RX]
> ifconfig [003] ..s1. 22993.928337: softirq_entry: vec=3 [action=NET_RX]
>
> Fixes: c2d548cad150 ("idpf: add TX splitq napi poll support")
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Signed-off-by: Alan Brady <alan.brady@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-02-09 10:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 0:42 [PATCH 1/1 iwl-net] idpf: disable local BH when scheduling napi for marker packets Alan Brady
2024-02-09 10:34 ` Simon Horman [this message]
2024-02-12 14:41 ` [Intel-wired-lan] " Alexander Lobakin
2024-02-12 17:43 ` Tantilov, Emil S
2024-02-13 13:16 ` Alexander Lobakin
2024-02-14 14:54 ` Alexander Lobakin
2024-02-14 15:39 ` Tantilov, Emil S
2024-02-15 13:28 ` Alexander Lobakin
2024-02-15 0:36 ` Jakub Kicinski
2024-03-05 0:44 ` Singh, Krishneil K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209103420.GD1516992@kernel.org \
--to=horms@kernel.org \
--cc=alan.brady@intel.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).