From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>, Shuah Khan <shuah@kernel.org>,
Willem de Bruijn <willemb@google.com>,
Coco Li <lixiaoyan@google.com>,
linux-kselftest@vger.kernel.org,
Matthieu Baerts <matttbe@kernel.org>
Subject: Re: [PATCH net v2] selftests: net: cope with slow env in gro.sh test
Date: Fri, 9 Feb 2024 11:15:50 -0800 [thread overview]
Message-ID: <20240209111550.1880ac56@kernel.org> (raw)
In-Reply-To: <c777f75ac70e70aabf1398cefa5c51c0f4ea00f2.1707330768.git.pabeni@redhat.com>
On Wed, 7 Feb 2024 19:36:46 +0100 Paolo Abeni wrote:
> + if [[ ${test} == "large" && -n "${KSFT_MACHINE_SLOW}" ]]; then
> + echo "Ignoring errors due to slow environment" 1>&2
> + exit_code=0
> + fi
Would it make sense to also add "&& $exit_code -ne 0" ?
It may be useful to see in logs how many times we actually
ignored the error?
next prev parent reply other threads:[~2024-02-09 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 18:36 [PATCH net v2] selftests: net: cope with slow env in gro.sh test Paolo Abeni
2024-02-07 22:14 ` Matthieu Baerts
2024-02-09 19:15 ` Jakub Kicinski [this message]
2024-02-12 8:40 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240209111550.1880ac56@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=lixiaoyan@google.com \
--cc=matttbe@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).