From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60DE216439 for ; Fri, 9 Feb 2024 21:11:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707513085; cv=none; b=DJCyUC5K1gkxKpc3gqD7Bv0O0aL/nszhzHhqkWNdaVlmcZxIIyMQs4/RF9ddEAin3KlOfWl+PfTlOU57SOv4A4hydosE8LJ1kwU3vIJPVqdvdaWx6WeIUGaKhM9C1gxHuo5ojIjxnKuuwQcxa+DVQy7JV/SWaKyZQmjr8Ip/cjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707513085; c=relaxed/simple; bh=XUcH1UxLCxfIwyJ9CRFC+7ICqDqroCA5cgXdrikWaRY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h76YW2gzhQoZa0rmJlo+Hpci4enM6TOW+lze4j3xOLpzR8Psfdnme0THO6j+iX31aGlJ6EfXRW4BagVU8TtcWihWoHPf5JxzInxB6g76dFrf88xhCc6vg3Ppi5oZXs1G5ISJo716hxF9Lf+LXiD76FyFeDvpXY4gNvqUWgA4fdY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=XtZKTBm/; arc=none smtp.client-ip=209.85.160.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="XtZKTBm/" Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2046b2cd2d3so954421fac.0 for ; Fri, 09 Feb 2024 13:11:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1707513082; x=1708117882; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=l6TgcwAbgsmLtLyu5Ofw1Dd466E2FrR34L8AWToaH3s=; b=XtZKTBm/Z7iEq+KpASrtQOEc3Q/EOxUyJs3Saw4h4NpnJHItCkXPFXdzi42DcvTBOH pZsN5nbUAfuruNVx5GoXepMIIpCgQd5EtvbfkLPXVgLMTAWr4fcsl8aQsugCV/RNr6yT 05dc8nvQ2Q2l5xw9tK2KQpaAMJnGpHhZLwSbFHtVEfr3GdGlNcF+h2cvtP5cfmNlnO5Y lhNS3pwhZkHBH7FB7EnFbuAkYlwCIFs5TUuDV2GsBAxYkhEsbMetRNY0Tqc71aqPVbP6 f40Ngtv1zmY7+0cqn25V7DUarhE1wWW0rpHpregX2WOsar1dGkdgOBoLkcAMKjpX34eU UTHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707513082; x=1708117882; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l6TgcwAbgsmLtLyu5Ofw1Dd466E2FrR34L8AWToaH3s=; b=YhrdSNQKRxB5QtWGWWKhzwnw981XgRgAm6Lioxa54XQl1jyPA7vlgOMrdnb1aWSurR YhI3nD3dIwj38Ntg8JMFLJWOM2bhxhnzD40S2IHhyug33j45N6T68WYx1QJOtXt+e9ib vlhq3BpXutw9/+egYBgpz/V4B00DPEQVJl4gSMj7JyKTASOX1c9BT4+9yWuIlsyN6dtO bRkD+pydQOHRlhqZZN2mR5BfaLb3SBjOMdfrrbDa2USGBYGaUTxwoQBREKyOeYAPah44 mXkSiyfpkzIunbPeCtyNXhpEgDimS2vq2DrmpVBVZ7WucYduLIvqFkIepeUQxChVAOOm jt4A== X-Gm-Message-State: AOJu0YyVqxySuVHX8hQ+wRRcBGZ0AXix22j3XGUdOXlset7I91uYlnJl 5fx9NQks29GEGlVUYDoTBkQOqXOY9DETlNvNeyeqgh6NTMAsAu7n/QbZx8Aqznw= X-Google-Smtp-Source: AGHT+IGl3bcIXf9vxhkEqrznfhES+9b4LRsM6WT2DoAnggZow6RhmartJWmHnoEjEXctYwPR1K8p3A== X-Received: by 2002:a05:6870:b250:b0:219:b163:70d8 with SMTP id b16-20020a056870b25000b00219b16370d8mr552722oam.6.1707513082402; Fri, 09 Feb 2024 13:11:22 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCXm3qqN7nurWgs9IaVrQ6JuoBgeVnXrUdVl39H6TG/U/U9XfNjgLSUynl36AntPvANxVhyPrAcht2SAT/qsUR1SWgM32c8saU0lm4578MElg9Mym2NaaOkFMFEtPMYsZxnZEKrVAKX3QLkDwEML4umP3Bq2P9v5yRwOIR1TXTjKj8gGHXbNWWctV9sKk6p4ZYW4gQ3y8FMeEpx3CkGvGa7KZxnpcVOVi2bUFH4q/x49qRl68MfMvnjk0uewdY0rCov92fBPwa7O3yypCTDysSJrWPuN0TmvB+hBqyDByVBJa6bylcoR7qjqdw27s7AU3GXCoURVufP5e5XaNUAqetK7A9CMOUFM5ksHcT56zwg/HOuaWGFmS6S1ES7OJXlQNMV8cKFlhO55G1XY0RppWhk2pLTJjlIVwv2iNZ1oFt3KEOCr3FnwQpXyeV83sdY0eXvLCZQk++lC6wzubsY0QzZBsQ8wUirg1IHvWNzht7zrvyy+POKQvf0RR+dTCnKG5r8FIpzanAory9C60cbXIMryjFS5e863M+S0Q5qxEX7t2g4Kst3xz/0jBfpu7nmUaiMK/za6cXUtXuaLedTjoNju0mvpixm/mGZ/T9s= Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id e21-20020a631e15000000b005d8e280c879sm2240643pge.84.2024.02.09.13.11.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Feb 2024 13:11:22 -0800 (PST) Date: Fri, 9 Feb 2024 13:11:19 -0800 From: Stephen Hemminger To: Jakub Kicinski Cc: netdev@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" , Eric Dumazet , Paolo Abeni , bpf@vger.kernel.org (open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH net-next v2] net/sched: actions report errors with extack Message-ID: <20240209131119.6399c91b@hermes.local> In-Reply-To: <20240208182731.682985dd@kernel.org> References: <20240205185537.216873-1-stephen@networkplumber.org> <20240208182731.682985dd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 8 Feb 2024 18:27:31 -0800 Jakub Kicinski wrote: > > - if (!tb[TCA_ACT_BPF_PARMS]) > > + if (NL_REQ_ATTR_CHECK(extack, nla, tb, TCA_ACT_BPF_PARMS)) { > > + NL_SET_ERR_MSG(extack, "Missing required attribute"); > > Please fix the userspace to support missing attr parsing instead. I was just addressing the error handling. This keeps the same impact as before, i.e no userspace API change.